From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v2 06/11] drm/i915/reg: fix PCH transcoder timing indentation
Date: Tue, 10 Sep 2024 16:39:28 +0300 [thread overview]
Message-ID: <ZuBMEGcugO7mN5q1@intel.com> (raw)
In-Reply-To: <f56e48a927692cec382e292602e0fa68e37f3b93.1725974820.git.jani.nikula@intel.com>
On Tue, Sep 10, 2024 at 04:28:50PM +0300, Jani Nikula wrote:
> Adhere to the style described at the top of i915_reg.h.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 2f09145b9791..1eede96a5415 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -3292,13 +3292,13 @@
>
> #define HSW_STEREO_3D_CTL(dev_priv, trans) _MMIO_PIPE2(dev_priv, trans, _HSW_STEREO_3D_CTL_A)
>
> -#define _PCH_TRANS_HTOTAL_B 0xe1000
> -#define _PCH_TRANS_HBLANK_B 0xe1004
> -#define _PCH_TRANS_HSYNC_B 0xe1008
> -#define _PCH_TRANS_VTOTAL_B 0xe100c
> -#define _PCH_TRANS_VBLANK_B 0xe1010
> -#define _PCH_TRANS_VSYNC_B 0xe1014
> -#define _PCH_TRANS_VSYNCSHIFT_B 0xe1028
> +#define _PCH_TRANS_HTOTAL_B 0xe1000
> +#define _PCH_TRANS_HBLANK_B 0xe1004
> +#define _PCH_TRANS_HSYNC_B 0xe1008
> +#define _PCH_TRANS_VTOTAL_B 0xe100c
> +#define _PCH_TRANS_VBLANK_B 0xe1010
> +#define _PCH_TRANS_VSYNC_B 0xe1014
> +#define _PCH_TRANS_VSYNCSHIFT_B 0xe1028
>
> #define PCH_TRANS_HTOTAL(pipe) _MMIO_PIPE(pipe, _PCH_TRANS_HTOTAL_A, _PCH_TRANS_HTOTAL_B)
> #define PCH_TRANS_HBLANK(pipe) _MMIO_PIPE(pipe, _PCH_TRANS_HBLANK_A, _PCH_TRANS_HBLANK_B)
> --
> 2.39.2
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2024-09-10 13:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 13:28 [PATCH v2 00/11] drm/i915: register style fixes Jani Nikula
2024-09-10 13:28 ` [PATCH v2 01/11] drm/i915/reg: fix transcoder timing register style Jani Nikula
2024-09-10 13:28 ` [PATCH v2 02/11] drm/i915/reg: fix g4x pipe data/link m/n " Jani Nikula
2024-09-10 13:28 ` [PATCH v2 03/11] drm/i915/reg: fix pipe conf, stat etc. " Jani Nikula
2024-09-10 13:28 ` [PATCH v2 04/11] drm/i915/reg: fix pipe data/link m/n " Jani Nikula
2024-09-10 13:28 ` [PATCH v2 05/11] drm/i915/reg: fix SKL scaler " Jani Nikula
2024-09-10 13:28 ` [PATCH v2 06/11] drm/i915/reg: fix PCH transcoder timing indentation Jani Nikula
2024-09-10 13:39 ` Ville Syrjälä [this message]
2024-09-11 14:38 ` Jani Nikula
2024-09-10 13:28 ` [PATCH v2 07/11] drm/i915/reg: fix PCH transcoder timing and data/link m/n style Jani Nikula
2024-09-10 13:28 ` [PATCH v2 08/11] drm/i915/reg: fix DIP CTL register style Jani Nikula
2024-09-10 13:28 ` [PATCH v2 09/11] drm/i915/reg: fix small register style issues here and there Jani Nikula
2024-09-10 13:28 ` [PATCH v2 10/11] drm/i915/reg: remove unused DSI register macros Jani Nikula
2024-09-10 13:28 ` [PATCH v2 11/11] drm/i915/reg: remove superfluous whitespace Jani Nikula
2024-09-10 14:44 ` ✓ CI.Patch_applied: success for drm/i915: register style fixes Patchwork
2024-09-10 14:45 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-10 14:46 ` ✓ CI.KUnit: success " Patchwork
2024-09-10 14:58 ` ✓ CI.Build: " Patchwork
2024-09-10 15:00 ` ✓ CI.Hooks: " Patchwork
2024-09-10 15:02 ` ✗ CI.checksparse: warning " Patchwork
2024-09-10 15:16 ` ✓ CI.BAT: success " Patchwork
2024-09-10 17:00 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2024-09-10 17:00 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-09-10 17:10 ` ✓ Fi.CI.BAT: success " Patchwork
2024-09-10 17:36 ` ✓ CI.FULL: " Patchwork
2024-09-11 8:57 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuBMEGcugO7mN5q1@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.