From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Prasad Pandit <ppandit@redhat.com>,
Yichen Wang <yichen.wang@bytedance.com>,
Bryan Zhang <bryan.zhang@bytedance.com>,
Hao Xiang <hao.xiang@linux.dev>, Yuan Liu <yuan1.liu@intel.com>
Subject: Re: [PATCH] migration/multifd: Fix build for qatzip
Date: Tue, 10 Sep 2024 17:59:45 -0400 [thread overview]
Message-ID: <ZuDBUSC2hVaWv6dE@x1n> (raw)
In-Reply-To: <87v7z3qjih.fsf@suse.de>
On Tue, Sep 10, 2024 at 06:35:50PM -0300, Fabiano Rosas wrote:
> Peter Xu <peterx@redhat.com> writes:
>
> > The qatzip series was based on an older commit, it applied cleanly even
> > though it has conflicts. Neither CI nor myself found the build will break
> > as it's skipped by default when qatzip library was missing.
>
> It took longer than I expected.
What took longer?
>
> Do you think it would work if we wrapped all calls to external functions
> in a header and stubbed them out when there's no accelerator support?
I didn't catch the major benefit v.s. multifd_register_ops(). Any further
elaborations?
--
Peter Xu
next prev parent reply other threads:[~2024-09-10 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 21:04 [PATCH] migration/multifd: Fix build for qatzip Peter Xu
2024-09-10 21:35 ` Fabiano Rosas
2024-09-10 21:59 ` Peter Xu [this message]
2024-09-10 22:32 ` Fabiano Rosas
2024-09-11 15:19 ` Peter Xu
2024-09-11 16:11 ` Fabiano Rosas
2024-09-10 22:15 ` [External] " Yichen Wang
2024-09-11 1:17 ` Liu, Yuan1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuDBUSC2hVaWv6dE@x1n \
--to=peterx@redhat.com \
--cc=bryan.zhang@bytedance.com \
--cc=farosas@suse.de \
--cc=hao.xiang@linux.dev \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yichen.wang@bytedance.com \
--cc=yuan1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.