From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Sam James <sam@gentoo.org>, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] tools: drop nonsensical -O6
Date: Wed, 11 Sep 2024 12:48:41 -0300 [thread overview]
Message-ID: <ZuG72Y_7XRkedEBz@x1> (raw)
In-Reply-To: <Zt9zoVFkFaCDwJ36@google.com>
On Mon, Sep 09, 2024 at 03:16:01PM -0700, Namhyung Kim wrote:
> Hello,
>
> On Sun, Sep 08, 2024 at 07:46:41PM +0100, Sam James wrote:
> > -O6 is very much not-a-thing. Really, this should've been dropped
> > entirely in 49b3cd306e60b9d889c775cb2ebb709f80dd8ae9 instead of just
> > passing it for not-Clang.
> >
> > Just collapse it down to -O3, instead of "-O6 unless Clang, in which case
> > -O3".
> >
> > GCC interprets > -O3 as -O3. It doesn't even interpret > -O3 as -Ofast,
> > which is a good thing, given -Ofast has specific (non-)requirements for
> > code built using it. So, this does nothing except look a bit daft.
> >
> > Remove the silliness and also save a few lines in the Makefiles accordingly.
> >
> > Signed-off-by: Sam James <sam@gentoo.org>
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, applied to perf-tools-next,
- Arnaldo
next prev parent reply other threads:[~2024-09-11 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-08 18:46 [PATCH] tools: drop nonsensical -O6 Sam James
2024-09-09 0:29 ` Ian Rogers
2024-09-09 22:16 ` Namhyung Kim
2024-09-11 15:48 ` Arnaldo Carvalho de Melo [this message]
2024-09-11 15:55 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuG72Y_7XRkedEBz@x1 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.