Re: [PATCH 1/2] drm/xe/display: Do not suspend resume dp mst during runtime

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Sep 11, 2024 at 08:57:23PM +0530, Suraj Kandpal wrote:
> Remove intel_dp_mst_suspend/resume from runtime suspend resume
> sequences. It is incorrect as it depends on AUX transfers which
> itself depend on the device being runtime resumed. This is
> also why we see a lock_dep splat here.

I pretty much agree with the intent... could you please provide
some pointers to the mentioned lockdep splat here in the commit
message?

and with that:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


> 
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
>  drivers/gpu/drm/xe/display/xe_display.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index c0e9aa7a274f..a09062b7687d 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -342,7 +342,8 @@ void xe_display_pm_suspend(struct xe_device *xe, bool runtime)
>  
>  	xe_display_flush_cleanup_work(xe);
>  
> -	intel_dp_mst_suspend(xe);
> +	if (!runtime)
> +		intel_dp_mst_suspend(xe);
>  
>  	intel_hpd_cancel_work(xe);
>  
> @@ -407,7 +408,9 @@ void xe_display_pm_resume(struct xe_device *xe, bool runtime)
>  		intel_display_driver_resume_access(xe);
>  
>  	/* MST sideband requires HPD interrupts enabled */
> -	intel_dp_mst_resume(xe);
> +	if (!runtime)
> +		intel_dp_mst_resume(xe);
> +
>  	if (!runtime && has_display(xe)) {
>  		intel_display_driver_resume(xe);
>  		drm_kms_helper_poll_enable(&xe->drm);
> -- 
> 2.43.2
>