All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Rob Herring <robh@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
	devicetree-spec@vger.kernel.org
Subject: Re: [PATCH dt-schema] schemas: i2c: add optional GPIO binding for SMBALERT# line
Date: Thu, 12 Sep 2024 08:35:18 +0200	[thread overview]
Message-ID: <ZuKLpilWKCS5k7Kx@shikoro> (raw)
In-Reply-To: <Zt_3WtlRP_5wt4PN@shikoro>

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]


> I had this originally in my RFC[1]. I got convinced by Geert's arguments
> because the DT snippet in the board DTS looked kinda ugly. The board
> needs to override the DTSI of the SoC to replace "interrupts" with
> "interrupts-extended":
> 
> ===
> 
>  &i2c3	{
>  	pinctrl-0 = <&i2c3_pins>;
>  	pinctrl-names = "i2c-pwr";
> +
> +	/delete-property/ interrupts;
> +	interrupts-extended = <&gic GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>, <&gpio1 26 IRQ_TYPE_EDGE_FALLING>;
> +	interrupt-names = "main", "smbus_alert";
> +
> +	smbus;
>  };
> 
> ===

I guess my questions here are: is this proper? Is there a better way to
describe it? Is using interrupts still the way to go?

Thanks for the guidance and happy hacking!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-09-12  6:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09 10:58 [PATCH dt-schema] schemas: i2c: add optional GPIO binding for SMBALERT# line Wolfram Sang
2024-09-09 13:07 ` Rob Herring
2024-09-09 13:30   ` Geert Uytterhoeven
2024-09-09 13:39     ` Rob Herring
2024-09-09 14:27       ` Geert Uytterhoeven
2024-09-09 18:24       ` Geert Uytterhoeven
2024-09-10  7:38       ` Wolfram Sang
2024-09-12  6:35         ` Wolfram Sang [this message]
2024-09-30 10:58           ` Wolfram Sang
2024-10-01 23:05 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZuKLpilWKCS5k7Kx@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=devicetree-spec@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.