All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v1 1/1] iio: light: ltr501: Drop most likely fake ACPI ID
Date: Fri, 13 Sep 2024 12:31:31 +0300	[thread overview]
Message-ID: <ZuQGcyrTFek1yExt@smile.fi.intel.com> (raw)
In-Reply-To: <c45dd21c-493a-4e56-809e-85d6d7201254@redhat.com>

On Thu, Sep 12, 2024 at 03:51:09PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 9/11/24 11:22 PM, Andy Shevchenko wrote:
> > The commit in question does not proove that ACPI ID exists.
> > Quite likely it was a cargo cult addition while doint that
> > for DT-based enumeration.  Drop most likely fake ACPI ID.
> > 
> > Googling for LTERxxxx gives no useful results in regard to DSDT.
> > Moreover, there is no "LTER" official vendor ID in the registry.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Thanks, patch looks good to me:

Have you grepped over your collection of real DSDTs?

> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Thank you!

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-09-13  9:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11 21:22 [PATCH v1 1/1] iio: light: ltr501: Drop most likely fake ACPI ID Andy Shevchenko
2024-09-12 13:51 ` Hans de Goede
2024-09-13  9:31   ` Andy Shevchenko [this message]
2024-09-14 14:25     ` Jonathan Cameron
2024-09-14 14:30       ` Hans de Goede
2024-09-14 15:06         ` Jonathan Cameron
2024-09-14 13:45   ` Hans de Goede
2024-09-16 10:00     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZuQGcyrTFek1yExt@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.