From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] uio: uio_dmem_genirq: Make use of irq_get_trigger_type()
Date: Fri, 13 Sep 2024 12:40:09 +0300 [thread overview]
Message-ID: <ZuQIeVAdC1O2xAM9@smile.fi.intel.com> (raw)
In-Reply-To: <20240912235925.54465-2-vassilisamir@gmail.com>
On Fri, Sep 13, 2024 at 01:59:24AM +0200, Vasileios Amoiridis wrote:
> Convert the following case:
>
> struct irq_data *irq_data = irq_get_irq_data(irq);
>
> if (irq_data && irqd_get_trigger_type(irq_data) ... ) {
> ...
> }
>
> to the simpler:
>
> if (irq_get_trigger_type(irq) ... ) {
> ...
> }
>
> by using the irq_get_trigger_type() function.
Btw, can you add a coccinelle ruleset for this?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-13 9:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 23:59 [PATCH v1 0/2] Use functionality of irq_get_trigger_type() Vasileios Amoiridis
2024-09-12 23:59 ` [PATCH v1 1/2] uio: uio_dmem_genirq: Make use " Vasileios Amoiridis
2024-09-13 9:40 ` Andy Shevchenko [this message]
2024-09-13 23:55 ` Vasileios Amoiridis
2024-09-12 23:59 ` [PATCH v1 2/2] uio: uio_pdrv_genirq: " Vasileios Amoiridis
2024-09-13 9:44 ` [PATCH v1 0/2] Use functionality " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuQIeVAdC1O2xAM9@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vassilisamir@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.