All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John B. Wyatt IV" <jwyatt@redhat.com>
To: Min-Hua Chen <minhuadotchen@gmail.com>
Cc: Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>,
	John Kacur <jkacur@redhat.com>,
	"John B . Wyatt IV" <sageofredondo@gmail.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 for-next] pm: cpupower: rename raw_pylibcpupower.i
Date: Fri, 13 Sep 2024 12:38:41 -0400	[thread overview]
Message-ID: <ZuRqkbJixRQEScYA@rhfedora> (raw)
In-Reply-To: <20240912230102.157534-1-minhuadotchen@gmail.com>

On Fri, Sep 13, 2024 at 07:01:00AM +0800, Min-Hua Chen wrote:

> To fix it, rename raw_pylibcpupower.i to raw_pylibcpupower.if.

Would you please rename this to .swg instead?

'''
5.1.1 Input format

As input, SWIG expects a file containing ISO C/C++ declarations and special
SWIG directives. More often than not, this is a special SWIG interface file
which is usually denoted with a special .i or .swg suffix.
'''

https://www.swig.org/Doc4.2/SWIG.html

I tested it and .swg is not removed by 'make clean' or 'make mrproper'.

My apologies for the extra work Min-Hua. I can send a quick patch
instead if you wish.

-- 
Sincerely,
John Wyatt
Software Engineer, Core Kernel
Red Hat


  reply	other threads:[~2024-09-13 16:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 23:01 [PATCH v2 for-next] pm: cpupower: rename raw_pylibcpupower.i Min-Hua Chen
2024-09-13 16:38 ` John B. Wyatt IV [this message]
2024-09-13 16:48   ` Shuah Khan
2024-09-13 19:58   ` Min-Hua Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZuRqkbJixRQEScYA@rhfedora \
    --to=jwyatt@redhat.com \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=minhuadotchen@gmail.com \
    --cc=sageofredondo@gmail.com \
    --cc=shuah@kernel.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.