From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Parker Newman <parker@finest.io>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH v1 1/6] misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle
Date: Fri, 13 Sep 2024 21:32:49 +0300 [thread overview]
Message-ID: <ZuSFUQPp0BdcFpx9@smile.fi.intel.com> (raw)
In-Reply-To: <20240913142420.675faf80@SWDEV2.connecttech.local>
On Fri, Sep 13, 2024 at 02:24:20PM -0400, Parker Newman wrote:
> On Fri, 13 Sep 2024 20:48:03 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, Sep 13, 2024 at 10:55:38AM -0400, Parker Newman wrote:
...
> > > Link: https://ww1.microchip.com/downloads/en/DeviceDoc/Atmel-5193-SEEPROM-AT93C46D-Datasheet.pdf
> >
> > Make it a tag (i.e. locate just above your SoB tag)
>
> Sorry, not 100% sure what you mean by tag? Do I just need to move the Link: entry
> to be above my Sign-off? Or is there something else? Thanks!
Make it like
...Summary...
<blank line>
...commit message text...
<blank line>
Link: ...
Signed-off-by: ...
...
> > > + if (has_quirk_extra_read_cycle(eeprom)) {
> > > + eeprom_93cx6_pulse_high(eeprom);
> >
> > No additional delay is needed?
>
> Should not need any extra delay as both pulse high/low functions have the worst case
> 450ns delay after the register write. It was working well on my test cards.
OK!
> > > + eeprom_93cx6_pulse_low(eeprom);
> > > + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-13 18:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 14:55 [PATCH v1 0/6] serial: 8250_exar: Replace custom EEPROM code with eeprom_93cx6 Parker Newman
2024-09-13 14:55 ` [PATCH v1 1/6] misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle Parker Newman
2024-09-13 17:48 ` Andy Shevchenko
2024-09-13 18:24 ` Parker Newman
2024-09-13 18:32 ` Andy Shevchenko [this message]
2024-09-13 14:55 ` [PATCH v1 2/6] misc: eeprom: eeprom_93cx6: Switch to BIT() macro Parker Newman
2024-09-13 17:48 ` Andy Shevchenko
2024-09-13 14:55 ` [PATCH v1 3/6] misc: eeprom: eeprom_93cx6: Replace printk(KERN_ERR ...) with pr_err() Parker Newman
2024-09-13 17:54 ` Andy Shevchenko
2024-09-13 19:12 ` Parker Newman
2024-09-13 19:26 ` Andy Shevchenko
2024-09-14 18:58 ` Greg Kroah-Hartman
2024-09-16 9:55 ` Andy Shevchenko
2024-09-16 10:25 ` Greg Kroah-Hartman
2024-09-16 10:32 ` Andy Shevchenko
2024-09-16 12:04 ` Parker Newman
2024-09-16 12:18 ` Andy Shevchenko
2024-09-16 15:20 ` Parker Newman
2024-09-16 15:27 ` Andy Shevchenko
2024-09-13 14:55 ` [PATCH v1 4/6] serial: 8250_exar: Replace custom EEPROM read with eeprom_93cx6 Parker Newman
2024-09-13 18:06 ` Andy Shevchenko
2024-09-14 13:26 ` kernel test robot
2024-09-16 10:09 ` Andy Shevchenko
2024-09-13 14:55 ` [PATCH v1 5/6] serial: 8250_exar: Remove old exar_ee_read() and other unneeded code Parker Newman
2024-09-13 18:07 ` Andy Shevchenko
2024-09-13 14:55 ` [PATCH v1 6/6] serial: 8250_exar: Add select EEPROM_93CX6 in Kconfig Parker Newman
2024-09-13 18:08 ` Andy Shevchenko
2024-09-13 18:10 ` [PATCH v1 0/6] serial: 8250_exar: Replace custom EEPROM code with eeprom_93cx6 Andy Shevchenko
2024-09-13 18:50 ` Parker Newman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuSFUQPp0BdcFpx9@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=parker@finest.io \
--cc=pnewman@connecttech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.