From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Thorsten Blum <thorsten.blum@toblux.com>,
kees@kernel.org, gustavoars@kernel.org, mcgrof@kernel.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2] params: Annotate struct module_param_attrs with __counted_by()
Date: Fri, 13 Sep 2024 21:40:07 +0300 [thread overview]
Message-ID: <ZuSHB2v7OLvagZnn@smile.fi.intel.com> (raw)
In-Reply-To: <20240913164630.GA4091534@thelio-3990X>
On Fri, Sep 13, 2024 at 09:46:30AM -0700, Nathan Chancellor wrote:
> On Mon, Sep 09, 2024 at 06:27:26PM +0200, Thorsten Blum wrote:
> > Add the __counted_by compiler attribute to the flexible array member
> > attrs to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
> > CONFIG_FORTIFY_SOURCE.
> >
> > Increment num before adding a new param_attribute to the attrs array and
> > adjust the array index accordingly. Increment num immediately after the
> > first reallocation such that the reallocation for the NULL terminator
> > only needs to add 1 (instead of 2) to mk->mp->num.
> >
> > Use struct_size() instead of manually calculating the size for the
> > reallocation.
> >
> > Use krealloc_array() for the additional NULL terminator.
> > /* Fix up all the pointers, since krealloc can move us */
> > for (i = 0; i < mk->mp->num; i++)
Shouldn't this for loop and followed by assignment also be -1:ed?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-13 18:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 16:27 [RESEND PATCH v2] params: Annotate struct module_param_attrs with __counted_by() Thorsten Blum
2024-09-11 17:59 ` Luis Chamberlain
2024-09-13 16:46 ` Nathan Chancellor
2024-09-13 16:55 ` Luis Chamberlain
2024-09-13 18:40 ` Andy Shevchenko [this message]
2024-09-13 19:03 ` Thorsten Blum
2024-09-13 19:09 ` Andy Shevchenko
2024-09-13 19:12 ` Andy Shevchenko
2024-09-13 23:32 ` Thorsten Blum
2024-09-13 23:44 ` Nathan Chancellor
2024-09-14 0:23 ` Thorsten Blum
2024-09-16 9:45 ` Bill Wendling
2024-09-17 11:43 ` Kees Cook
-- strict thread matches above, loose matches on Subject: below --
2024-12-21 9:48 Thorsten Blum
2025-01-07 10:55 Thorsten Blum
2025-01-14 21:49 Thorsten Blum
2025-02-04 16:44 ` Thorsten Blum
2025-02-11 13:18 ` Thorsten Blum
2025-02-13 21:51 ` Luis Chamberlain
2025-02-13 22:13 Thorsten Blum
2025-02-13 22:21 ` Luis Chamberlain
2025-02-17 10:04 ` Petr Pavlu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuSHB2v7OLvagZnn@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gustavoars@kernel.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nathan@kernel.org \
--cc=thorsten.blum@toblux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.