From: Matthew Wilcox <willy@infradead.org>
To: Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Simon Horman <horms@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
LEROY Christophe <christophe.leroy2@cs-soprasteria.com>
Subject: Re: [PATCH net-next v1] mm: fix build on powerpc with GCC 14
Date: Fri, 13 Sep 2024 20:22:28 +0100 [thread overview]
Message-ID: <ZuSQ9BT9Vg7O2kXv@casper.infradead.org> (raw)
In-Reply-To: <20240913192036.3289003-1-almasrymina@google.com>
On Fri, Sep 13, 2024 at 07:20:36PM +0000, Mina Almasry wrote:
> +++ b/include/linux/page-flags.h
> @@ -239,8 +239,8 @@ static inline unsigned long _compound_head(const struct page *page)
> {
> unsigned long head = READ_ONCE(page->compound_head);
>
> - if (unlikely(head & 1))
> - return head - 1;
> + if (unlikely(head & 1UL))
> + return head & ~1UL;
> return (unsigned long)page_fixed_fake_head(page);
NAK, that pessimises compound_head().
next prev parent reply other threads:[~2024-09-13 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 19:20 [PATCH net-next v1] mm: fix build on powerpc with GCC 14 Mina Almasry
2024-09-13 19:22 ` Matthew Wilcox [this message]
2024-09-14 6:50 ` Christophe Leroy
2024-09-15 10:44 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuSQ9BT9Vg7O2kXv@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=arnd@arndb.de \
--cc=christophe.leroy2@cs-soprasteria.com \
--cc=davem@davemloft.net \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.