All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Alexander Zubkov <green@qrator.net>, pabeni@redhat.com
Cc: linux-kernel@vger.kernel.org, linux-newbie@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH] Fix misspelling of "accept*"
Date: Sun, 15 Sep 2024 16:25:09 +0000	[thread overview]
Message-ID: <ZucKZcwmd28S_t24@gallifrey> (raw)
In-Reply-To: <CABr+u0b-RAV9hz25O5a3Axz6s9vYLVc5shr8xAgPsykP_XRFgw@mail.gmail.com>

* Alexander Zubkov (green@qrator.net) wrote:
> Hi,
> 
> I just wanted to kindly check in on the status of my patch. Please let
> me know if any further action is needed from my side.
> 
> Thanks for your time!

I was only a reviewer on this; it'll need some of the netdev people
to notice it for it to get further.

Dave

> Best regards,
> Alexander Zubkov
> 
> On Sat, Jun 22, 2024 at 10:14 PM Dr. David Alan Gilbert
> <linux@treblig.org> wrote:
> >
> > * Alexander Zubkov (green@qrator.net) wrote:
> > > Several files have "accept*" misspelled as "accpet*" in the comments.
> > > Fix all such occurrences.
> > >
> > > Signed-off-by: Alexander Zubkov <green@qrator.net>
> >
> > Reviewed-by: Dr. David Alan Gilbert <linux@treblig.org>
> >
> > hmm, should probably cc in some maintainers, I guess networking.
> > (added netdev and Paolo)
> >
> > Dave
> >
> > > ---
> > >  drivers/infiniband/hw/irdma/cm.c                              | 2 +-
> > >  drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c | 4 ++--
> > >  drivers/net/ethernet/natsemi/ns83820.c                        | 2 +-
> > >  include/uapi/linux/udp.h                                      | 2 +-
> > >  4 files changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/hw/irdma/cm.c b/drivers/infiniband/hw/irdma/cm.c
> > > index 36bb7e5ce..ce8d821bd 100644
> > > --- a/drivers/infiniband/hw/irdma/cm.c
> > > +++ b/drivers/infiniband/hw/irdma/cm.c
> > > @@ -3631,7 +3631,7 @@ void irdma_free_lsmm_rsrc(struct irdma_qp *iwqp)
> > >  /**
> > >   * irdma_accept - registered call for connection to be accepted
> > >   * @cm_id: cm information for passive connection
> > > - * @conn_param: accpet parameters
> > > + * @conn_param: accept parameters
> > >   */
> > >  int irdma_accept(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
> > >  {
> > > diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> > > index 455a54708..96fd31d75 100644
> > > --- a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> > > +++ b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c
> > > @@ -342,8 +342,8 @@ static struct sk_buff *copy_gl_to_skb_pkt(const struct pkt_gl *gl,
> > >  {
> > >       struct sk_buff *skb;
> > >
> > > -     /* Allocate space for cpl_pass_accpet_req which will be synthesized by
> > > -      * driver. Once driver synthesizes cpl_pass_accpet_req the skb will go
> > > +     /* Allocate space for cpl_pass_accept_req which will be synthesized by
> > > +      * driver. Once driver synthesizes cpl_pass_accept_req the skb will go
> > >        * through the regular cpl_pass_accept_req processing in TOM.
> > >        */
> > >       skb = alloc_skb(gl->tot_len + sizeof(struct cpl_pass_accept_req)
> > > diff --git a/drivers/net/ethernet/natsemi/ns83820.c b/drivers/net/ethernet/natsemi/ns83820.c
> > > index 998586872..bea969dfa 100644
> > > --- a/drivers/net/ethernet/natsemi/ns83820.c
> > > +++ b/drivers/net/ethernet/natsemi/ns83820.c
> > > @@ -2090,7 +2090,7 @@ static int ns83820_init_one(struct pci_dev *pci_dev,
> > >        */
> > >       /* Ramit : 1024 DMA is not a good idea, it ends up banging
> > >        * some DELL and COMPAQ SMP systems
> > > -      * Turn on ALP, only we are accpeting Jumbo Packets */
> > > +      * Turn on ALP, only we are accepting Jumbo Packets */
> > >       writel(RXCFG_AEP | RXCFG_ARP | RXCFG_AIRL | RXCFG_RX_FD
> > >               | RXCFG_STRIPCRC
> > >               //| RXCFG_ALP
> > > diff --git a/include/uapi/linux/udp.h b/include/uapi/linux/udp.h
> > > index 1a0fe8b15..d85d671de 100644
> > > --- a/include/uapi/linux/udp.h
> > > +++ b/include/uapi/linux/udp.h
> > > @@ -31,7 +31,7 @@ struct udphdr {
> > >  #define UDP_CORK     1       /* Never send partially complete segments */
> > >  #define UDP_ENCAP    100     /* Set the socket to accept encapsulated packets */
> > >  #define UDP_NO_CHECK6_TX 101 /* Disable sending checksum for UDP6X */
> > > -#define UDP_NO_CHECK6_RX 102 /* Disable accpeting checksum for UDP6 */
> > > +#define UDP_NO_CHECK6_RX 102 /* Disable accepting checksum for UDP6 */
> > >  #define UDP_SEGMENT  103     /* Set GSO segmentation size */
> > >  #define UDP_GRO              104     /* This socket can receive UDP GRO packets */
> > >
> > > --
> > > 2.45.2
> > >
> > >
> > --
> >  -----Open up your eyes, open up your mind, open up your code -------
> > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
> > \        dave @ treblig.org |                               | In Hex /
> >  \ _________________________|_____ http://www.treblig.org   |_______/
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

  reply	other threads:[~2024-09-15 16:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-22 16:40 [PATCH] Fix misspelling of "accept*" Alexander Zubkov
2024-06-22 20:14 ` Dr. David Alan Gilbert
2024-09-15 14:29   ` Alexander Zubkov
2024-09-15 16:25     ` Dr. David Alan Gilbert [this message]
2024-09-15 18:54       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZucKZcwmd28S_t24@gallifrey \
    --to=linux@treblig.org \
    --cc=green@qrator.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-newbie@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.