All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Kocialkowski <paulk@sys-base.io>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: tony@atomide.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Kevin Hilman <khilman@baylibre.com>,
	Paul Kocialkowski <contact@paulk.fr>
Subject: Re: [PATCH] ARM: dts: omap4-kc1: fix twl6030 power node
Date: Mon, 16 Sep 2024 12:36:30 +0200	[thread overview]
Message-ID: <ZugKLiRZrrDpdI_W@collins> (raw)
In-Reply-To: <20240915193527.1071792-1-andreas@kemnade.info>

[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]

Hi Andreas,

Le Sun 15 Sep 24, 21:35, Andreas Kemnade a écrit :
> dtbs_check was moaning about twl6030-power, use the standard property
> instead.
> Apparently that twl6030 power snippet slipped in without the
> corresponding driver. Now it is handled by the standard property.

Thanks for the fix! LGTM.

Reviewed-by: Paul Kocialkowski <contact@paulk.fr>

Cheers,

Paul

> CC: Paul Kocialkowski <contact@paulk.fr>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/ti/omap/omap4-kc1.dts | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/omap4-kc1.dts b/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
> index c6b79ba8bbc91..df874d5f5327f 100644
> --- a/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
> +++ b/arch/arm/boot/dts/ti/omap/omap4-kc1.dts
> @@ -112,11 +112,7 @@ twl: twl@48 {
>  		reg = <0x48>;
>  		/* IRQ# = 7 */
>  		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N cascaded to gic */
> -
> -		twl_power: power {
> -			compatible = "ti,twl6030-power";
> -			ti,system-power-controller;
> -		};
> +		system-power-controller;
>  	};
>  };
>  
> -- 
> 2.39.2
> 

-- 
Paul Kocialkowski,

Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/

Expertise in multimedia, graphics and embedded hardware support with Linux.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-09-16 10:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-15 19:35 [PATCH] ARM: dts: omap4-kc1: fix twl6030 power node Andreas Kemnade
2024-09-16 10:36 ` Paul Kocialkowski [this message]
2024-10-04 21:40 ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZugKLiRZrrDpdI_W@collins \
    --to=paulk@sys-base.io \
    --cc=andreas@kemnade.info \
    --cc=conor+dt@kernel.org \
    --cc=contact@paulk.fr \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.