All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Raphaël Mélotte" <raphael.melotte@mind.be>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 3/4] package/python-sdbus-networkmanager: new package
Date: Mon, 16 Sep 2024 13:17:44 +0200	[thread overview]
Message-ID: <ZugT2E3Y1M3TjNt_@landeda> (raw)
In-Reply-To: <20240705091409.3370272-3-raphael.melotte@mind.be>

Raphaël, All,

On 2024-07-05 11:14 +0200, Raphaël Mélotte via buildroot spake thusly:
> Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
> ---
[--SNIP--]
> diff --git a/package/python-sdbus-networkmanager/Config.in b/package/python-sdbus-networkmanager/Config.in
> new file mode 100644
> index 0000000000..70ec11414c
> --- /dev/null
> +++ b/package/python-sdbus-networkmanager/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_PYTHON_SDBUS_NETWORKMANAGER
> +	bool "python-sdbus-networkmanager"
> +	depends on BR2_PACKAGE_NETWORK_MANAGER # runtime
> +	select BR2_PACKAGE_PYTHON_SDBUS # runtime

You forgot to propagate the dependencies from pytrhon-sdbus.

> +	help
> +	  NetworkManager binds for sdbus.

s/binds/bindings/

> +	  https://github.com/igo95862/python-sdbus
> +
> +comment "python-sdbus-networkmanager needs network-manager"
> +	depends on !BR2_PACKAGE_NETWORK_MANAGER

You'll alspo need to update the dependencies list of the comment.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-09-16 11:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 14:57 [Buildroot] [PATCH 1/4] package/python-sdbus: new package Raphaël Mélotte via buildroot
2024-07-01 14:57 ` [Buildroot] [PATCH 2/4] support/testing: add new test for python-sdbus Raphaël Mélotte via buildroot
2024-07-01 14:57 ` [Buildroot] [PATCH 3/4] package/python-sdbus-networkmanager: new package Raphaël Mélotte via buildroot
2024-07-03 21:38   ` Romain Naour via buildroot
2024-07-01 14:57 ` [Buildroot] [PATCH 4/4] support/testing: add new test for python-sdbus-networkmanager Raphaël Mélotte via buildroot
2024-07-03 21:32 ` [Buildroot] [PATCH 1/4] package/python-sdbus: new package Romain Naour via buildroot
2024-07-05  9:18   ` Raphaël Mélotte via buildroot
2024-07-05  9:14 ` [Buildroot] [PATCH v2 " Raphaël Mélotte via buildroot
2024-07-05  9:14   ` [Buildroot] [PATCH v2 2/4] support/testing: add new test for python-sdbus Raphaël Mélotte via buildroot
2024-07-05  9:14   ` [Buildroot] [PATCH v2 3/4] package/python-sdbus-networkmanager: new package Raphaël Mélotte via buildroot
2024-09-16 11:17     ` Yann E. MORIN [this message]
2024-09-16 11:32       ` Yann E. MORIN
2024-07-05  9:14   ` [Buildroot] [PATCH v2 4/4] support/testing: add new test for python-sdbus-networkmanager Raphaël Mélotte via buildroot
2024-09-16 11:30   ` [Buildroot] [PATCH v2 1/4] package/python-sdbus: new package Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZugT2E3Y1M3TjNt_@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=asafka7@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    --cc=raphael.melotte@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.