From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D95415ADB3 for ; Mon, 16 Sep 2024 21:11:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726521105; cv=none; b=lb/JD1mqki4tGgwvRK6K5K2XtQsCC4O5/2dzlrIsPS2ZgmDdnYyym28nVsRwGsU76IIceWlGC19yqR/l5BQyKLf9vRtF/YibNkuRuXBxHtZM4w0RC+P2wmE55s8PyvlhKEI6585h25Pkpxlh0kGNl3cyMQ7If4+v9GjjPrSYIms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726521105; c=relaxed/simple; bh=PGZ+lU1HRyuy6hJNYWsBOyMK/QUaQG7boXIMjaKBVmM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=FO2VxlUWklxgtz/l1UdkzrIuELUFcXZ5oM14rOZYVgJWEHxhweO4cfQ0ZViHup37X0+GDRMJ6k2uOYXXCXhgvPi+5g+lSkfH+G2zQXR8aEaOf0pOkBbPNG1WHobDJm0iFNRo9RWw4INDqKwkhG7/6JTk3lUGvgi7R7LgncxV0DM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=A/ps+2/1; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A/ps+2/1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726521102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0QBTWCGXcISLwCtlbiJhxDX2TLS3XLjwMHvnpH2GAf8=; b=A/ps+2/1As+QFSCA0VxiGrwUhLYP0AtqDh7Syhw07mF5OS0/adqrSPpT8kiBUZ5y2PfOpp Dfwwoq0WLIkXzVmp5y9uBprhMQ2iPNIhFCe6ssj1ASvNznCAgJwVxmb4yshf8AeYIzORyg nGapkaMk06Q8BKMt2hNCiBtK72c5jzk= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-349-kHUq6zbMObecFqtmijOSXw-1; Mon, 16 Sep 2024 17:11:40 -0400 X-MC-Unique: kHUq6zbMObecFqtmijOSXw-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 99E9F1955BD2; Mon, 16 Sep 2024 21:11:39 +0000 (UTC) Received: from bmarzins-01.fast.eng.rdu2.dc.redhat.com (bmarzins-01.fast.eng.rdu2.dc.redhat.com [10.6.23.12]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 365DB1956086; Mon, 16 Sep 2024 21:11:39 +0000 (UTC) Received: from bmarzins-01.fast.eng.rdu2.dc.redhat.com (localhost [127.0.0.1]) by bmarzins-01.fast.eng.rdu2.dc.redhat.com (8.17.2/8.17.1) with ESMTPS id 48GLBbBo930683 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 16 Sep 2024 17:11:37 -0400 Received: (from bmarzins@localhost) by bmarzins-01.fast.eng.rdu2.dc.redhat.com (8.17.2/8.17.2/Submit) id 48GLBbZK930682; Mon, 16 Sep 2024 17:11:37 -0400 Date: Mon, 16 Sep 2024 17:11:37 -0400 From: Benjamin Marzinski To: Martin Wilck Cc: Christophe Varoqui , device-mapper development Subject: Re: [PATCH v2 00/22] Yet Another path checker refactor Message-ID: References: <20240912214947.783819-1-bmarzins@redhat.com> Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 13, 2024 at 11:30:23AM +0200, Martin Wilck wrote: > On Thu, 2024-09-12 at 17:49 -0400, Benjamin Marzinski wrote: > > This patchset cleans up some of the ugly code from my last refactor, > > and > > speeds up multipathd path checking, by refactoring how paths are > > checked. > > > > I haven't started reviewing this yet, but I'm seeing a CI problem with > the sysfs test, only with clang 18 on Fedora 40: > https://github.com/openSUSE/multipath-tools/actions/runs/10845899189 I'm not sure what this is and I've been entirely unable to reproduce it using Fedora 40 and clang 18.1.8 (the current f40 version of clang). It seems pretty obvious that I has nothing to do with my patchset. It looks like it's related to the renaming open() issues. Given the "%s() has remaining non-returned values." and "__wrap___open64_2: '%s' parameter still has values that haven't been checked." messages, I'm guessing something other than __open64_2() was called. But like I said, I can't reproduce this. -Ben > > Martin