From: Christoph Hellwig <hch@infradead.org>
To: fdmanana@kernel.org
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH] fstests: fix min_dio_alignment logic for getting device block size
Date: Mon, 16 Sep 2024 22:20:45 -0700 [thread overview]
Message-ID: <ZukRreQ--325baAG@infradead.org> (raw)
In-Reply-To: <0d6ec0b588b578b9f9aabef91b8ecdf9950b682a.1726488132.git.fdmanana@suse.com>
On Mon, Sep 16, 2024 at 01:03:12PM +0100, fdmanana@kernel.org wrote:
> Fix this by checking that the ioctl succeeded.
The fixes look good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
What file do you manage to open but fail BLKSSZGET on here? This smells
like we have an issue in high level logic.
And btrfs really should implement STATX_DIOALIGN with it's multi-device
setup that doesn't make the fallback very useful.
>
next prev parent reply other threads:[~2024-09-17 5:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 12:03 [PATCH] fstests: fix min_dio_alignment logic for getting device block size fdmanana
2024-09-16 21:28 ` Darrick J. Wong
2024-09-17 5:20 ` Christoph Hellwig [this message]
2024-09-17 10:07 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZukRreQ--325baAG@infradead.org \
--to=hch@infradead.org \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.