From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH 0/2] migration/multifd: Fix rb->receivedmap cleanup race
Date: Tue, 17 Sep 2024 16:01:20 -0400 [thread overview]
Message-ID: <ZungELnuhdCXeYeZ@x1n> (raw)
In-Reply-To: <20240917185802.15619-1-farosas@suse.de>
On Tue, Sep 17, 2024 at 03:58:00PM -0300, Fabiano Rosas wrote:
> v2: Keep skipping the cpu_synchronize_all_post_init() call if the
> postcopy listen thread is live. Don't copy stable on the first patch.
>
> CI run: https://gitlab.com/farosas/qemu/-/pipelines/1457418838
> ====
> v1:
> https://lore.kernel.org/r/20240913220542.18305-1-farosas@suse.de
>
> This fixes the crash we've been seing recently in migration-test. The
> first patch is a cleanup to have only one place calling
> qemu_loadvm_state_cleanup() and the second patch reorders the cleanup
> calls to make multifd_recv_cleanup() run first and stop the recv
> threads.
>
> Fabiano Rosas (2):
> migration/savevm: Remove extra load cleanup calls
> migration/multifd: Fix rb->receivedmap cleanup race
queued.
Let's see whether this can quiesce all multifd cancel test failures.. If
not, we can still follow that up.
--
Peter Xu
next prev parent reply other threads:[~2024-09-17 20:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 18:58 [PATCH 0/2] migration/multifd: Fix rb->receivedmap cleanup race Fabiano Rosas
2024-09-17 18:58 ` [PATCH 1/2] migration/savevm: Remove extra load cleanup calls Fabiano Rosas
2024-09-17 19:16 ` Peter Xu
2024-09-17 19:20 ` Fabiano Rosas
2024-09-17 18:58 ` [PATCH 2/2] migration/multifd: Fix rb->receivedmap cleanup race Fabiano Rosas
2024-09-17 19:20 ` Peter Xu
2024-09-17 19:29 ` Fabiano Rosas
2024-09-17 20:01 ` Peter Xu [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-09-13 22:05 [PATCH 0/2] " Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZungELnuhdCXeYeZ@x1n \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.