Re: [PULL 14/18] virtio-pci: Add lookup subregion of VirtIOPCIRegion MR

[Peter Xu <peterx@redhat.com>]

On Wed, Sep 11, 2024 at 09:52:08AM -0400, Michael S. Tsirkin wrote:
> From: Gao Shiyuan <gaoshiyuan@baidu.com>
> 
> Now virtio_address_space_lookup only lookup common/isr/device/notify
> MR and exclude their subregions.
> 
> When VHOST_USER_PROTOCOL_F_HOST_NOTIFIER enable, the notify MR has
> host-notifier subregions and we need use host-notifier MR to
> notify the hardware accelerator directly instead of eventfd notify.
> 
> Further more, maybe common/isr/device MR also has subregions in
> the future, so need memory_region_find for each MR incluing
> their subregions.
> 
> Add lookup subregion of VirtIOPCIRegion MR instead of only lookup container MR.
> 
> Fixes: a93c8d8 ("virtio-pci: Replace modern_as with direct access to modern_bar")
> Co-developed-by: Zuo Boqun <zuoboqun@baidu.com>
> Signed-off-by: Gao Shiyuan <gaoshiyuan@baidu.com>
> Signed-off-by: Zuo Boqun <zuoboqun@baidu.com>
> Message-Id: <20240903120304.97833-1-gaoshiyuan@baidu.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Hi,

QEMU master currently crashes with below cmdlines on my system:

qemu_bin=./qemu-system-x86_64
$qemu_bin -accel kvm -m 4g \
          -name peter-vm,debug-threads=on -msg timestamp=on \
          -nographic -cpu host -smp 4 \
          -device ioh3420,id=pcie.1,chassis=1 \
          -netdev user,id=net0 \
          -device virtio-net-pci,netdev=net0,bus=pcie.1

qemu-system-x86_64: ../hw/virtio/virtio-pci.c:620: virtio_address_space_lookup: Assertion `mrs.mr' failed.

Bisection goes to this patch..

Thanks,

-- 
Peter Xu