From: Michal Hocko <mhocko@suse.com>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <kees@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, "Paul E. McKenney" <paulmck@kernel.org>,
Neeraj Upadhyay <neeraj.upadhyay@kernel.org>,
Joel Fernandes <joel@joelfernandes.org>,
Boqun Feng <boqun.feng@gmail.com>,
Zqiang <qiang.zhang1211@gmail.com>,
rcu@vger.kernel.org
Subject: Re: [PATCH 12/19] kthread: Default affine kthread to its preferred NUMA node
Date: Wed, 18 Sep 2024 13:17:09 +0200 [thread overview]
Message-ID: <Zuq2tVC8GlBJwUJ7@tiehlicka> (raw)
In-Reply-To: <ZuqfZhvWB5ox4nh3@localhost.localdomain>
On Wed 18-09-24 11:37:42, Frederic Weisbecker wrote:
> Le Tue, Sep 17, 2024 at 01:07:25PM +0200, Michal Hocko a écrit :
[...]
> > I am not objecting to patch per se. I am just not sure this is really
> > needed. It is great to have kernel threads bound to non isolated cpus by
> > default if they have node preferences. But as soon as somebody starts
> > offlining cpus excessively and make the initial cpumask empty then
> > select_fallback_rq sounds like the right thing to do.
> >
> > Not my call though. I was just curious why this is needed and it seems
> > to me you are looking for some sort of correctness for broken setups.
>
> It looks like it makes sense to explore that path. We still need the
> cpu up probe to reaffine when a suitable target comes up. But it seems
> the CPU down part can be handled by select_fallback_rq. I'll try that.
THanks! Btw. when you are looking at this, would it make sense to make
select_fallback_rq more cpu isolation aware as well? I mean using
housekeeping cpus before falling back to task_cpu_possible_mask?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2024-09-18 11:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 22:49 [PATCH 00/19] kthread: Introduce preferred affinity v3 Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 01/19] arm/bL_switcher: Use kthread_run_on_cpu() Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 02/19] x86/resctrl: " Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 03/19] firmware: stratix10-svc: " Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 04/19] scsi: bnx2fc: Use kthread_create_on_cpu() Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 05/19] scsi: bnx2i: " Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 06/19] scsi: qedi: " Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 07/19] soc/qman: test: Use kthread_run_on_cpu() Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 08/19] kallsyms: " Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 09/19] lib: test_objpool: " Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 10/19] net: pktgen: Use kthread_create_on_node() Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 11/19] kthread: Make sure kthread hasn't started while binding it Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 12/19] kthread: Default affine kthread to its preferred NUMA node Frederic Weisbecker
2024-09-17 6:26 ` Michal Hocko
2024-09-17 7:01 ` Vlastimil Babka
2024-09-17 7:05 ` Michal Hocko
2024-09-17 7:14 ` Vlastimil Babka
2024-09-17 10:34 ` Frederic Weisbecker
2024-09-17 11:07 ` Michal Hocko
2024-09-18 9:37 ` Frederic Weisbecker
2024-09-18 11:17 ` Michal Hocko [this message]
2024-09-16 22:49 ` [PATCH 13/19] mm: Create/affine kcompactd to its preferred node Frederic Weisbecker
2024-09-17 6:04 ` Michal Hocko
2024-09-16 22:49 ` [PATCH 14/19] mm: Create/affine kswapd " Frederic Weisbecker
2024-09-17 6:05 ` Michal Hocko
2024-09-16 22:49 ` [PATCH 15/19] kthread: Implement preferred affinity Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 16/19] rcu: Use kthread preferred affinity for RCU boost Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 17/19] kthread: Unify kthread_create_on_cpu() and kthread_create_worker_on_cpu() automatic format Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 18/19] treewide: Introduce kthread_run_worker[_on_cpu]() Frederic Weisbecker
2024-09-16 22:49 ` [PATCH 19/19] rcu: Use kthread preferred affinity for RCU exp kworkers Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2024-12-11 15:40 [PATCH 00/19] kthread: Introduce preferred affinity v6 Frederic Weisbecker
2024-12-11 15:40 ` [PATCH 12/19] kthread: Default affine kthread to its preferred NUMA node Frederic Weisbecker
2024-08-07 16:02 [PATCH 00/19] kthread: Introduce preferred affinity v2 Frederic Weisbecker
2024-08-07 16:02 ` [PATCH 12/19] kthread: Default affine kthread to its preferred NUMA node Frederic Weisbecker
2024-08-07 17:01 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zuq2tVC8GlBJwUJ7@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=neeraj.upadhyay@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=qiang.zhang1211@gmail.com \
--cc=rcu@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.