All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dave@treblig.org>
To: Jag Raman <jag.raman@oracle.com>
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: of remote_iohub_finalize
Date: Thu, 19 Sep 2024 15:12:58 +0000	[thread overview]
Message-ID: <Zuw_erEDSNMyQldP@gallifrey> (raw)
In-Reply-To: <38410E7A-7058-466A-ADAC-AFA494BF4890@oracle.com>

* Jag Raman (jag.raman@oracle.com) wrote:
> Hi Dave,
> 
> Thanks for checking!
> 
> remote_iohub_finalize() is a relic from when remote iohub was a separate type. We aren't calling it anywhere; we can remove it.

OK, I'll send a patch later.

Dave

> Cheers,
> Jag
> 
> > On Sep 18, 2024, at 1:00 PM, Dr. David Alan Gilbert <dave@treblig.org> wrote:
> > 
> > Hi Jag,
> >  One of my scripts noticed that 'remote_iohub_finalize' in
> > hw/remote/iohub.c is unused; before I go and delete it as deadcode,
> > is that actually just a missing call somewhere?
> > 
> > Dave
> > 
> > -- 
> > -----Open up your eyes, open up your mind, open up your code -------   
> > / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
> > \        dave @ treblig.org |                               | In Hex /
> > \ _________________________|_____ http://www.treblig.org   |_______/
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/


      reply	other threads:[~2024-09-19 15:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-18 17:00 of remote_iohub_finalize Dr. David Alan Gilbert
2024-09-19 15:12 ` Jag Raman
2024-09-19 15:12   ` Dr. David Alan Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zuw_erEDSNMyQldP@gallifrey \
    --to=dave@treblig.org \
    --cc=elena.ufimtseva@oracle.com \
    --cc=jag.raman@oracle.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.