From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Ray Liu <ray.liu@airoha.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Andy Shevchenko <andy@kernel.org>,
Christian Marangi <ansuelsmth@gmail.com>,
linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
upstream@airoha.com
Subject: Re: (subset) [PATCH 0/4] spi: airoha: Fix errors reported by mtd_test kernel modules
Date: Thu, 19 Sep 2024 14:36:39 +0200 [thread overview]
Message-ID: <Zuwa1wtNJQQIGvAg@lore-desk> (raw)
In-Reply-To: <ZuwZIN6bPzlmB_Ly@finisterre.sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
On Sep 19, Mark Brown wrote:
> On Thu, Sep 19, 2024 at 01:18:09PM +0200, Lorenzo Bianconi wrote:
>
> > ack. The issue is the 'read cache' logic present in the vendor sdk codebase I
> > added in the upstream driver is buggy and it is introducing errors reported
> > by mtd_oobtest kernel test module. Since we do not get any read/write speed
> > improvement using the cache, in order to fix the mtd_oobtest test, I decided
> > to get rid of the 'read cache' since it is not useful. Now the driver is passing
> > all the tests available in mtd_test suite.
> > Do you want me to repost just this patch updating the commit log?
>
> It'd be a bit easier to resend this and patch 4 but yes. Please mention
> exactly what the errors that mtd_oobtest finds are and ideally why
> removing the cache fixes them in the changelog.
ack, I will do.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-09-19 12:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 21:07 [PATCH 0/4] spi: airoha: Fix errors reported by mtd_test kernel modules Lorenzo Bianconi
2024-09-13 21:07 ` [PATCH 1/4] spi: airoha: fix dirmap_{read,write} operations Lorenzo Bianconi
2024-09-13 21:07 ` [PATCH 2/4] spi: airoha: fix airoha_snand_{write,read}_data data_len estimation Lorenzo Bianconi
2024-09-13 21:07 ` [PATCH 3/4] spi: airoha: remove read cache in airoha_snand_dirmap_read Lorenzo Bianconi
2024-09-13 21:07 ` [PATCH 4/4] spi: airoha: do not keep {tx,rx} dma buffer always mapped Lorenzo Bianconi
2024-09-19 8:29 ` (subset) [PATCH 0/4] spi: airoha: Fix errors reported by mtd_test kernel modules Mark Brown
2024-09-19 8:59 ` Lorenzo Bianconi
2024-09-19 9:05 ` Mark Brown
2024-09-19 9:16 ` Lorenzo Bianconi
2024-09-19 10:44 ` Mark Brown
2024-09-19 11:18 ` Lorenzo Bianconi
2024-09-19 12:29 ` Mark Brown
2024-09-19 12:36 ` Lorenzo Bianconi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zuwa1wtNJQQIGvAg@lore-desk \
--to=lorenzo@kernel.org \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=ray.liu@airoha.com \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.