All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John B. Wyatt IV" <jwyatt@redhat.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>,
	John Kacur <jkacur@redhat.com>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow overriding cross-compiling envs
Date: Thu, 19 Sep 2024 12:38:39 -0400	[thread overview]
Message-ID: <ZuxTjy7I-pZBcXa0@rhfedora> (raw)
In-Reply-To: <20240919-pm-v2-0-0f25686556b5@nxp.com>

Hi Peng,

A few comments:

> V2:
>  subject update, commit log update in patch 1, 2
>  Use strerror in patch 1
>  without patch 2, need update Makefile with 'CROSS =
>  [cross toolchain path]/aarch64-poky-linux-'

Version information is applied per commit patch. Not in the cover letter.

Example:

https://lore.kernel.org/linux-pm/20240905021916.15938-2-jwyatt@redhat.com/

Reference:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

You will need to submit a V3 version of this.

>  without patch 2, need update Makefile with 'CROSS =
>  [cross toolchain path]/aarch64-poky-linux-'

I am not sure what this is saying exactly. Please clarify.

> Subject: Re: [PATCH v2 0/2] tools: power: cpupower: Allow overriding

Not sure you need 'tools: power: cpupower:' in the cover letter.

> pm: cpupower: bench: print config file path when open cpufreq-bench.conf fails

I do not think you need bench either.

-- 
Sincerely,
John Wyatt
Software Engineer, Core Kernel
Red Hat


  parent reply	other threads:[~2024-09-19 16:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-19 12:08 [PATCH v2 0/2] tools: power: cpupower: Allow overriding cross-compiling envs Peng Fan (OSS)
2024-09-19 12:08 ` [PATCH v2 1/2] pm: cpupower: bench: print config file path when open cpufreq-bench.conf fails Peng Fan (OSS)
2024-09-19 12:08 ` [PATCH v2 2/2] pm: cpupower: Makefile: Allow overriding cross-compiling env params Peng Fan (OSS)
2024-11-21  4:41   ` Florian Fainelli
2024-11-21 12:40     ` Peng Fan
2024-11-21 17:02       ` Florian Fainelli
2024-11-22  0:13         ` Peng Fan
2024-11-22 17:34           ` Florian Fainelli
2024-11-29  0:38             ` Peng Fan
2024-09-19 16:38 ` John B. Wyatt IV [this message]
2024-09-20  8:58   ` [PATCH v2 0/2] tools: power: cpupower: Allow overriding cross-compiling envs Peng Fan
2024-09-20  9:01     ` Peng Fan
2024-09-20 12:41       ` John B. Wyatt IV
2024-09-20 12:44       ` John B. Wyatt IV
2024-09-23  6:26         ` Peng Fan
2024-09-30 15:52           ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZuxTjy7I-pZBcXa0@rhfedora \
    --to=jwyatt@redhat.com \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=shuah@kernel.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.