Re: [PATCH] q35: Remove unused mch_mcfg_base

["Dr. David Alan Gilbert" <dave@treblig.org>]

* Bernhard Beschow (shentey@gmail.com) wrote:
> 
> 
> Am 18. September 2024 00:51:32 UTC schrieb dave@treblig.org:
> >From: "Dr. David Alan Gilbert" <dave@treblig.org>
> >
> >mch_mcfg_base has been unused since it was added by
> >  6f1426ab0f ("ich9: APIs for pc guest info")
> >back in 2013.
> 
> Indeed.
> 
> >
> >Remove it.
> >
> >Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> 
> Reviewed-by: Bernhard Beschow <shentey@gmail.com>

Thanks!

> I'm curious: How do you detect such unused code?

I've got a very hacky script that looks for symbols that
are defined but nothing else uses; it generates a lot of
false positives so takes a lot of handholding to find
real cases.
See: https://lore.kernel.org/lkml/ZugliLgw5VFb9yau@gallifrey/

Dave

> >---
> > hw/pci-host/q35.c         | 10 ----------
> > include/hw/pci-host/q35.h |  2 --
> > 2 files changed, 12 deletions(-)
> >
> >diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
> >index d5a657a02a..f3e713318e 100644
> >--- a/hw/pci-host/q35.c
> >+++ b/hw/pci-host/q35.c
> >@@ -662,16 +662,6 @@ static void mch_realize(PCIDevice *d, Error **errp)
> >                                    OBJECT(&mch->smram));
> > }
> > 
> >-uint64_t mch_mcfg_base(void)
> >-{
> >-    bool ambiguous;
> >-    Object *o = object_resolve_path_type("", TYPE_MCH_PCI_DEVICE, &ambiguous);
> >-    if (!o) {
> >-        return 0;
> >-    }
> >-    return MCH_HOST_BRIDGE_PCIEXBAR_DEFAULT;
> >-}
> >-
> > static Property mch_props[] = {
> >     DEFINE_PROP_UINT16("extended-tseg-mbytes", MCHPCIState, ext_tseg_mbytes,
> >                        16),
> >diff --git a/include/hw/pci-host/q35.h b/include/hw/pci-host/q35.h
> >index 22fadfa3ed..ddafc3f2e3 100644
> >--- a/include/hw/pci-host/q35.h
> >+++ b/include/hw/pci-host/q35.h
> >@@ -181,8 +181,6 @@ struct Q35PCIHost {
> > #define MCH_PCIE_DEV                           1
> > #define MCH_PCIE_FUNC                          0
> > 
> >-uint64_t mch_mcfg_base(void);
> >-
> > /*
> >  * Arbitrary but unique BNF number for IOAPIC device.
> >  *
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/