From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 821EECF31B0 for ; Wed, 2 Oct 2024 10:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VeHB+y7rcpoghbzXl5KSETnOGMC/eBt9uY5ZmG1Lmm4=; b=b0UljchNaCypl+JgmH21O2YfyR jx1yDV3f9IB1+ilZd2Z/GEDgqau0wQvcB2nd7sewU0j/z0mh1G+QJ9kLBsl7cmxG0NnTVWBc3rFyV 8/1hVQSZohaFsRYwlBjVMMzLnvGZursnbXV4fe5jFo5NGFGFMIuuKLMQpDPZem9np+P/dtwbq3f/w 74jiM0l3bNNxQ1oWUIuHFtCpOnMvNvjGUGZebKNOHsv5YTUxH5rlIk97TiEbm6e1LZENYs9reSWUp g3gY9PUaRxDg+HRXsVg9cjUFhS2r/emWxkvmjHR0TTnI0V569OeGDQSNPU9jIMmgpMRZQmbg61KYg 4sKfPB5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svwcP-00000005UfI-3Ix5; Wed, 02 Oct 2024 10:30:05 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svwar-00000005USI-1ocu for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2024 10:28:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 33DB55C3CAC; Wed, 2 Oct 2024 10:28:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8D0BC4CEC5; Wed, 2 Oct 2024 10:28:26 +0000 (UTC) Date: Wed, 2 Oct 2024 11:28:24 +0100 From: Catalin Marinas To: Kristina Martsenko Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , Mark Rutland , Robin Murphy , Marc Zyngier Subject: Re: [PATCH 1/5] arm64: probes: Disable kprobes/uprobes on MOPS instructions Message-ID: References: <20240930161051.3777828-1-kristina.martsenko@arm.com> <20240930161051.3777828-2-kristina.martsenko@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240930161051.3777828-2-kristina.martsenko@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241002_032829_534305_E7EF5C60 X-CRM114-Status: GOOD ( 10.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 30, 2024 at 05:10:47PM +0100, Kristina Martsenko wrote: > FEAT_MOPS instructions require that all three instructions (prologue, > main and epilogue) appear consecutively in memory. Placing a > kprobe/uprobe on one of them doesn't work as only a single instruction > gets executed out-of-line or simulated. So don't allow placing a probe > on a MOPS instruction. > > Fixes: b7564127ffcb ("arm64: mops: detect and enable FEAT_MOPS") > Signed-off-by: Kristina Martsenko I think this would benefit from a cc stable: Cc: # 6.5.x I can add it when applying the patch. -- Catalin