From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/3] Filter mkfs version in tst_fs
Date: Wed, 2 Oct 2024 13:08:20 +0200 [thread overview]
Message-ID: <Zv0ppHP00NOAIL2f@yuki.lan> (raw)
In-Reply-To: <998c91c2-e967-4423-aab4-41c28164d63f@suse.com>
Hi!
> > + if (fs->mkfs_ver && tst_check_cmd(fs->mkfs_ver, 1))
> > + return TCONF;
> > +
> sounds good to me. Perhaps I just noticed that "ret" value is never used
> by run_tcases_per_fs method. that has to be fixed I guess..
That was my mistake when adding the per-fs parameters and I've send a
patch to fix that yesterday.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-10-02 11:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 13:52 [LTP] [PATCH v2 0/3] Fix ioctl_ficlone(range) failures on certain FS Andrea Cervesato
2024-10-01 13:52 ` [LTP] [PATCH v2 1/3] Filter mkfs version in tst_fs Andrea Cervesato
2024-10-01 15:12 ` Cyril Hrubis
2024-10-02 11:06 ` Andrea Cervesato via ltp
2024-10-02 11:08 ` Cyril Hrubis [this message]
2024-10-01 13:52 ` [LTP] [PATCH v2 2/3] Add minimum kernel requirement for FS setup Andrea Cervesato
2024-10-01 15:29 ` Cyril Hrubis
2024-10-01 13:52 ` [LTP] [PATCH v2 3/3] Setup minimal kernel for ioctl_clone(range) tests Andrea Cervesato
2024-10-01 15:33 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv0ppHP00NOAIL2f@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.