From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4 07/13] Add statmount02 test
Date: Wed, 2 Oct 2024 17:15:21 +0200 [thread overview]
Message-ID: <Zv1jiTboCX0cutqr@yuki.lan> (raw)
In-Reply-To: <20240909-listmount_statmount-v4-7-39558204ddf0@suse.com>
Hi!
> +static void run(void)
> +{
> + memset(st_mount, 0, sizeof(struct statmount));
> +
> + TST_EXP_PASS(statmount(sx_mount->data.stx_mnt_id, STATMOUNT_SB_BASIC,
> + st_mount, sizeof(struct statmount), 0));
> +
> + if (TST_RET == -1)
> + return;
Same here if (!TST_PASS)
The rest looks good:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-10-02 15:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 10:00 [LTP] [PATCH v4 00/13] statmount/listmount testing suites Andrea Cervesato
2024-09-09 10:00 ` [LTP] [PATCH v4 01/13] Add SAFE_STATX macro Andrea Cervesato
2024-09-09 16:21 ` Andrea Cervesato via ltp
2024-10-02 12:27 ` Cyril Hrubis
2024-10-02 13:00 ` Andrea Cervesato via ltp
2024-09-09 10:00 ` [LTP] [PATCH v4 02/13] Add listmount/statmount syscalls Andrea Cervesato
2024-10-02 12:30 ` Cyril Hrubis
2024-09-09 10:00 ` [LTP] [PATCH v4 03/13] Add listmount/statmount fallback declarations Andrea Cervesato
2024-10-02 14:12 ` Cyril Hrubis
2024-09-09 10:00 ` [LTP] [PATCH v4 04/13] Add listmount01 test Andrea Cervesato
2024-10-02 14:05 ` Cyril Hrubis
2024-10-02 14:14 ` Cyril Hrubis
2024-09-09 10:00 ` [LTP] [PATCH v4 05/13] Add listmount02 test Andrea Cervesato
2024-10-02 14:37 ` Cyril Hrubis
2024-09-09 10:00 ` [LTP] [PATCH v4 06/13] Add statmount01 test Andrea Cervesato
2024-10-02 14:45 ` Cyril Hrubis
2024-09-09 10:00 ` [LTP] [PATCH v4 07/13] Add statmount02 test Andrea Cervesato
2024-10-02 15:15 ` Cyril Hrubis [this message]
2024-09-09 10:00 ` [LTP] [PATCH v4 08/13] Add statmount03 test Andrea Cervesato
2024-10-03 13:27 ` Cyril Hrubis
2024-09-09 10:00 ` [LTP] [PATCH v4 09/13] Add statmount04 test Andrea Cervesato
2024-10-03 13:51 ` Cyril Hrubis
2024-09-09 10:00 ` [LTP] [PATCH v4 10/13] Add statmount05 test Andrea Cervesato
2024-10-03 14:09 ` Cyril Hrubis
2024-09-09 10:00 ` [LTP] [PATCH v4 11/13] Add TST_EXP_EQ_STR macro Andrea Cervesato
2024-10-03 14:13 ` Cyril Hrubis
2024-09-09 10:00 ` [LTP] [PATCH v4 12/13] Add statmount06 test Andrea Cervesato
2024-10-03 14:20 ` Cyril Hrubis
2024-09-09 10:00 ` [LTP] [PATCH v4 13/13] Add statmount07 test Andrea Cervesato
2024-10-03 14:34 ` Cyril Hrubis
2024-10-04 8:19 ` Andrea Cervesato via ltp
2024-10-04 9:17 ` Cyril Hrubis
2024-10-04 11:03 ` Andrea Cervesato via ltp
2024-10-04 12:02 ` Jan Kara
2024-10-03 14:42 ` [LTP] [PATCH v4 00/13] statmount/listmount testing suites Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv1jiTboCX0cutqr@yuki.lan \
--to=chrubis@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.