From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: "Daniel P. Smith" <dpsmith@apertussolutions.com>
Cc: "Frediano Ziglio" <frediano.ziglio@cloud.com>,
xen-devel@lists.xenproject.org, "Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v7 1/2] x86/boot: Rewrite EFI/MBI2 code partly in C
Date: Thu, 3 Oct 2024 13:40:36 +0200 [thread overview]
Message-ID: <Zv6CtSPdVqkJHQLT@mail-itl> (raw)
In-Reply-To: <1adbaea9-40b8-4cec-9871-599fde168925@apertussolutions.com>
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
On Wed, Oct 02, 2024 at 10:31:50AM -0400, Daniel P. Smith wrote:
> On 10/1/24 06:22, Frediano Ziglio wrote:
> > No need to have it coded in assembly.
> > Declare efi_multiboot2 in a new header to reuse between implementations
> > and caller.
> >
> > Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
>
> I unfortunately do not have time to test this myself, but I have given a
> read through and it looks good to me. I will give it an R-b and let Marek
> provide the A-b when he is comfortable that CI failure is an artifact of the
> test system and not this series.
>
> Reviewed-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Since it seems it's only the other patch causing issues, for this one:
Acked-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-10-03 11:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 10:22 [PATCH v7 0/2] x86/boot: Reduce assembly code Frediano Ziglio
2024-10-01 10:22 ` [PATCH v7 1/2] x86/boot: Rewrite EFI/MBI2 code partly in C Frediano Ziglio
2024-10-02 6:48 ` Jan Beulich
2024-10-02 14:31 ` Daniel P. Smith
2024-10-03 11:40 ` Marek Marczykowski-Górecki [this message]
2024-10-01 10:22 ` [PATCH v7 2/2] x86/boot: Improve MBI2 structure check Frediano Ziglio
2024-10-01 16:02 ` Jan Beulich
2024-10-03 12:57 ` Frediano Ziglio
2024-10-02 14:04 ` [PATCH v7 0/2] x86/boot: Reduce assembly code Marek Marczykowski-Górecki
2024-10-02 15:27 ` Frediano Ziglio
2024-10-03 1:11 ` Marek Marczykowski-Górecki
2024-10-03 7:46 ` Andrew Cooper
2024-10-03 9:27 ` Frediano Ziglio
2024-10-03 10:46 ` Marek Marczykowski-Górecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv6CtSPdVqkJHQLT@mail-itl \
--to=marmarek@invisiblethingslab.com \
--cc=andrew.cooper3@citrix.com \
--cc=dpsmith@apertussolutions.com \
--cc=frediano.ziglio@cloud.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.