From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Date: Thu, 3 Oct 2024 15:39:17 +0300 Subject: [PATCH v14 0/3] Add ASPEED AST2600 I2Cv2 controller driver In-Reply-To: References: <20241002070213.1165263-1-ryan_chen@aspeedtech.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Oct 03, 2024 at 02:20:54PM +0200, Andi Shyti wrote: > On Thu, Oct 03, 2024 at 01:15:50PM GMT, Andy Shevchenko wrote: > > On Thu, Oct 03, 2024 at 03:41:57AM +0000, Ryan Chen wrote: > > > > On Wed, Oct 02, 2024 at 03:02:10PM +0800, Ryan Chen wrote: ... > > > > Is it possible to switch to new terminology wherever it's possible? > > > > I.e. master --> controller, slave --> target. See, for example, f872d28500bd > > > > ("i2c: uniphier-f: reword according to newest specification"). > > > > > > > Just for cover latter? Or I should modify for each patches commit message? > > > Or entire i2c driver statement need switch to target? > > > > I believe everywhere, where it applies: driver code, comments, documentation, > > commit messages... > > If the datasheet refers to a register, state, or any other > hardware property as master/slave, we should retain the > master/slave terminology. Otherwise, we should follow the i2c and > smbus specifications and use controller/target. Indeed, makes sense. Thank you, Andi, for the corrections! -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12310186E42; Thu, 3 Oct 2024 12:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727959168; cv=none; b=i7cZN0d1aXVzPOOAfqUEFt8dj6lq6AmDnCq08E6WYS1aZWQ3v32E+RcF+QWQIiDKvROQkhIyAOskzsESgK5GEoxZSkXvjXSXNHw8/FTA9N1VuQqQIDCoThUcLmVtPrmvLCadUQW/T/qNqE5OP0w2gVCJeDdHr3McQK0LS/zELdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727959168; c=relaxed/simple; bh=jJqZlWZyRRWoe9bZ1pTGj+NsxagcVSsJs5dIspW8QMY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r1JpEJ4EwHOWMBl2LkrPxA65u7tSl11BuDlrhe7ECp+OjuBGfhON06Sj1ueDJ+RtX2lrtdLRIsSFiZgqegMrk9swphxGYRJf2eRyug/z8EXXZOat6GTkNH+yEky2gZv7i5RsMP1mMr1ZFvQWMGNeX+vlMfL744o61AtwZmnpoXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DQcExD/t; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DQcExD/t" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727959166; x=1759495166; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jJqZlWZyRRWoe9bZ1pTGj+NsxagcVSsJs5dIspW8QMY=; b=DQcExD/t6LGZAyZr5rqu4MuMqZ4559rIo9EqHQ7HOeqmQ/knjmD1swI+ pjM5ItyW6Vnz4HOhIH15VtMWVC9P05N5/O16t30MS/F6AfleC0pRSsQie Zc1bV10uOaRpJrtDySoFnfYsDZYX8UMxHR6QaVEQ3uqmgN+H8hGDZxGfO 5F4kV3TTT107bnrrhuMJFIriZxyFtnNoUFeUY1aqJMmvTGFA3CiS2N3j2 Jmnpb6ohkqZ4qzDdr+1gIks86k6EbHLHHZb+u1KPQT2JPt5+EiRf+xjvo U6RG1Vvr5blNKeoKxbj5wzckXpK4VsF8Izot5yGFxGSA42L9HRhypdqrd w==; X-CSE-ConnectionGUID: epIsiQW8TNa0Ns7XenoPvQ== X-CSE-MsgGUID: UlWk40AGQH+5XwVjQjR27g== X-IronPort-AV: E=McAfee;i="6700,10204,11214"; a="14766788" X-IronPort-AV: E=Sophos;i="6.11,174,1725346800"; d="scan'208";a="14766788" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2024 05:39:25 -0700 X-CSE-ConnectionGUID: VZ4FQ9ZJTiukwSGcRxIw8w== X-CSE-MsgGUID: Q+m6TP+eSkKye7Bb4NxYAQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,174,1725346800"; d="scan'208";a="74188410" Received: from unknown (HELO smile.fi.intel.com) ([10.237.72.154]) by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2024 05:39:22 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1swL70-0000000G8x5-0KUx; Thu, 03 Oct 2024 15:39:18 +0300 Date: Thu, 3 Oct 2024 15:39:17 +0300 From: Andy Shevchenko To: Andi Shyti Cc: Ryan Chen , "brendan.higgins@linux.dev" , "benh@kernel.crashing.org" , "joel@jms.id.au" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "andrew@codeconstruct.com.au" , "p.zabel@pengutronix.de" , "linux-i2c@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v14 0/3] Add ASPEED AST2600 I2Cv2 controller driver Message-ID: References: <20241002070213.1165263-1-ryan_chen@aspeedtech.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Oct 03, 2024 at 02:20:54PM +0200, Andi Shyti wrote: > On Thu, Oct 03, 2024 at 01:15:50PM GMT, Andy Shevchenko wrote: > > On Thu, Oct 03, 2024 at 03:41:57AM +0000, Ryan Chen wrote: > > > > On Wed, Oct 02, 2024 at 03:02:10PM +0800, Ryan Chen wrote: ... > > > > Is it possible to switch to new terminology wherever it's possible? > > > > I.e. master --> controller, slave --> target. See, for example, f872d28500bd > > > > ("i2c: uniphier-f: reword according to newest specification"). > > > > > > > Just for cover latter? Or I should modify for each patches commit message? > > > Or entire i2c driver statement need switch to target? > > > > I believe everywhere, where it applies: driver code, comments, documentation, > > commit messages... > > If the datasheet refers to a register, state, or any other > hardware property as master/slave, we should retain the > master/slave terminology. Otherwise, we should follow the i2c and > smbus specifications and use controller/target. Indeed, makes sense. Thank you, Andi, for the corrections! -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6516ECF34A2 for ; Thu, 3 Oct 2024 12:39:50 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4XKB8B1R5Qz2yVd for ; Thu, 3 Oct 2024 22:39:38 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=192.198.163.16 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1727959173; cv=none; b=mEtewm+e1bKdwhJyyNnOIPa33gc0osz/ZM/aDe4lOQMxxf+U6kdTKbjzUw738RZ16tg7JYYKmar2X08U8T3MJn0HM5GfXAQm1mEKfaYbG4jM7O4QG7Et4lSVdK4hARBwmxLdJEW5AKrX62MN6DMV5hBDpdULpjTFO7HIynu0sHLm+pTbPEZ3hn5l+Y4Mep7aWL5Dq1NUA5wrBpMpS6OXfXewk7Pe8nzbOf6i+IrGCMFq7aLQTEasCLvwT5K3sYt3nZ+HRgULLJZZM/OKVf+ZQnDEW1p+kfRsyFlOoxUapJioRKIX+jqQb3JbjFeClcxP32IG66WVVOtrBEwvRadOvQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1727959173; c=relaxed/relaxed; bh=bqoVeqJgqT0M1flxfT93zxVXlDysL5pQlp7hNngjZ0w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=T62YqaaTf/924nkgIicQnUVoXlEjrzsr8dTLutm9+17ma/NAcLnlxesC99cFTH76np1+ncab/i90YAOjeRKVCxrGsG6l4pTBmLeEyL4BdV7MTqvpDgrQV6/NqSUMCX2gy4/iGhiBaHfOYWPgXEPUycUNp6iwFHoC3cP6V+zZJes57SJmqikna+iHDoBe4zzVItkreJ0rNObPbUPyjZ5NPIppXxks7ODJVLhNSgaROWn9/dO40ZpMZss+WKmTX3EpClKCrGk7cBC69Sx5Xjoa1sTVt/N4CMIUqTSERaIjuElACwA7gVoVnV8FfFJBFZwlu4dGPO2bYvhw8h93IwrwmQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=iSKhYUoB; dkim-atps=neutral; spf=none (client-ip=192.198.163.16; helo=mgamail.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=iSKhYUoB; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=192.198.163.16; helo=mgamail.intel.com; envelope-from=andriy.shevchenko@linux.intel.com; receiver=lists.ozlabs.org) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4XKB814Nklz2yR3; Thu, 3 Oct 2024 22:39:27 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727959170; x=1759495170; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jJqZlWZyRRWoe9bZ1pTGj+NsxagcVSsJs5dIspW8QMY=; b=iSKhYUoBLVw9mB80jX53I/XjRaetvMDbPP3WT7j5+5RdUoexaG3sH4jw GGL3bjQCWQnV0gWANCPG+2KiQvdZbB6fiBKrhJvEZU6ZB4wvA5gPutOQw MAJDvKwv08GNaHpgxhH2BIEWAlqwgJnO9YhOqo84fN8mJNuAHf35kevLC /1Y0SXcYmHRK65XYCmwp/T8eoYXP1gLf7lNkbJUGEmti0a96KB3HKJmmb Pzp7dr9fQmIqUQDzBCC6FEbrFwqaU7XJfWtfuk/TafU+w73LeSo7Unob6 8zffxnmLK9es/W3JAPbYsXUcPYLw7kceXXI/IuOX0NjBQ7lR6jnwtjS/i w==; X-CSE-ConnectionGUID: o0b/XQ4xTFqwIStH3HbzsA== X-CSE-MsgGUID: bdQA9fGIQvKPXcEzMSj8kw== X-IronPort-AV: E=McAfee;i="6700,10204,11214"; a="14766781" X-IronPort-AV: E=Sophos;i="6.11,174,1725346800"; d="scan'208";a="14766781" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2024 05:39:25 -0700 X-CSE-ConnectionGUID: VZ4FQ9ZJTiukwSGcRxIw8w== X-CSE-MsgGUID: Q+m6TP+eSkKye7Bb4NxYAQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,174,1725346800"; d="scan'208";a="74188410" Received: from unknown (HELO smile.fi.intel.com) ([10.237.72.154]) by orviesa010.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Oct 2024 05:39:22 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1swL70-0000000G8x5-0KUx; Thu, 03 Oct 2024 15:39:18 +0300 Date: Thu, 3 Oct 2024 15:39:17 +0300 From: Andy Shevchenko To: Andi Shyti Subject: Re: [PATCH v14 0/3] Add ASPEED AST2600 I2Cv2 controller driver Message-ID: References: <20241002070213.1165263-1-ryan_chen@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "robh@kernel.org" , "conor+dt@kernel.org" , Ryan Chen , "linux-aspeed@lists.ozlabs.org" , "devicetree@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "brendan.higgins@linux.dev" , "joel@jms.id.au" , "p.zabel@pengutronix.de" , "krzk+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-i2c@vger.kernel.org" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, Oct 03, 2024 at 02:20:54PM +0200, Andi Shyti wrote: > On Thu, Oct 03, 2024 at 01:15:50PM GMT, Andy Shevchenko wrote: > > On Thu, Oct 03, 2024 at 03:41:57AM +0000, Ryan Chen wrote: > > > > On Wed, Oct 02, 2024 at 03:02:10PM +0800, Ryan Chen wrote: ... > > > > Is it possible to switch to new terminology wherever it's possible? > > > > I.e. master --> controller, slave --> target. See, for example, f872d28500bd > > > > ("i2c: uniphier-f: reword according to newest specification"). > > > > > > > Just for cover latter? Or I should modify for each patches commit message? > > > Or entire i2c driver statement need switch to target? > > > > I believe everywhere, where it applies: driver code, comments, documentation, > > commit messages... > > If the datasheet refers to a register, state, or any other > hardware property as master/slave, we should retain the > master/slave terminology. Otherwise, we should follow the i2c and > smbus specifications and use controller/target. Indeed, makes sense. Thank you, Andi, for the corrections! -- With Best Regards, Andy Shevchenko