All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Fomichev <stfomichev@gmail.com>
To: Mina Almasry <almasrymina@google.com>
Cc: Stanislav Fomichev <sdf@fomichev.me>,
	netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next v2 11/12] selftests: ncdevmem: Move ncdevmem under drivers/net/hw
Date: Thu, 3 Oct 2024 10:25:59 -0700	[thread overview]
Message-ID: <Zv7TpwAgpVs2SjyH@mini-arch> (raw)
In-Reply-To: <CAHS8izN6ePwKyRLtn2pdZjZwCQd6gyE_3OU2QvGRg0r9=2z3rw@mail.gmail.com>

On 10/03, Mina Almasry wrote:
> On Mon, Sep 30, 2024 at 10:18 AM Stanislav Fomichev <sdf@fomichev.me> wrote:
> >
> > This is where all the tests that depend on the HW functionality live in
> > and this is where the automated test is gonna be added in the next
> > patch.
> >
> 
> Tbh I don't like this very much. I wanted to take ncdevmem in the
> opposite direction: to make at least the control path tests runnable
> on netdevsim or something like that and have it not require any HW
> support at all.
> 
> But I see in the cover letter that Jakub himself asked for the move,
> so if there is some strong reason to make this in hw, sure.
> 
> Does it being under HW preclude future improvements to making it a
> non-HW dependent test?

I'm moving it under drivers/net/hw only because I want ncdevmem to end
up as a TEST_GEN_FILES dependency (drivers/net/hw is the directory
that the vendors will eventually run against their HW so this is
where the HW-dependent tests are gonna stay for now). And I'm not sure I
can do a cross directory dependency in TEST_GEN_FILES. But maybe I
haven't looked hard enough?

Let's not marry too much to the location? When you get ncdevmem
working with netdevsim, we can move the file to a different location.

  reply	other threads:[~2024-10-03 17:26 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 17:17 [PATCH net-next v2 00/12] selftests: ncdevmem: Add ncdevmem to ksft Stanislav Fomichev
2024-09-30 17:17 ` [PATCH net-next v2 01/12] selftests: ncdevmem: Redirect all non-payload output to stderr Stanislav Fomichev
2024-10-03 17:40   ` Mina Almasry
2024-09-30 17:17 ` [PATCH net-next v2 02/12] selftests: ncdevmem: Separate out dmabuf provider Stanislav Fomichev
2024-10-03 17:57   ` Mina Almasry
2024-10-03 22:08     ` Stanislav Fomichev
2024-10-04  1:42       ` Mina Almasry
2024-09-30 17:17 ` [PATCH net-next v2 03/12] selftests: ncdevmem: Unify error handling Stanislav Fomichev
2024-10-03  6:57   ` Mina Almasry
2024-09-30 17:17 ` [PATCH net-next v2 04/12] selftests: ncdevmem: Make client_ip optional Stanislav Fomichev
2024-10-03  6:56   ` Mina Almasry
2024-09-30 17:17 ` [PATCH net-next v2 05/12] selftests: ncdevmem: Remove default arguments Stanislav Fomichev
2024-10-03  6:59   ` Mina Almasry
2024-10-03 16:36     ` Stanislav Fomichev
2024-10-03 18:51       ` Mina Almasry
2024-09-30 17:17 ` [PATCH net-next v2 06/12] selftests: ncdevmem: Switch to AF_INET6 Stanislav Fomichev
2024-10-03  7:07   ` Mina Almasry
2024-10-03 16:47     ` Stanislav Fomichev
2024-10-03 17:16       ` Mina Almasry
2024-09-30 17:17 ` [PATCH net-next v2 07/12] selftests: ncdevmem: Properly reset flow steering Stanislav Fomichev
2024-10-03  7:02   ` Mina Almasry
2024-10-03 16:42     ` Stanislav Fomichev
2024-10-03 18:54       ` Mina Almasry
2024-10-03 22:12         ` Stanislav Fomichev
2024-09-30 17:17 ` [PATCH net-next v2 08/12] selftests: ncdevmem: Use YNL to enable TCP header split Stanislav Fomichev
2024-10-03  7:22   ` Mina Almasry
2024-10-03 16:57     ` Stanislav Fomichev
2024-09-30 17:17 ` [PATCH net-next v2 09/12] selftests: ncdevmem: Remove hard-coded queue numbers Stanislav Fomichev
2024-10-03  7:14   ` Mina Almasry
2024-10-03 17:02     ` Stanislav Fomichev
2024-10-03 19:07       ` Mina Almasry
2024-10-03 22:16         ` Stanislav Fomichev
2024-09-30 17:17 ` [PATCH net-next v2 10/12] selftests: ncdevmem: Run selftest when none of the -s or -c has been provided Stanislav Fomichev
2024-10-03  7:26   ` Mina Almasry
2024-10-03 17:18     ` Stanislav Fomichev
2024-10-03 19:10       ` Mina Almasry
2024-09-30 17:17 ` [PATCH net-next v2 11/12] selftests: ncdevmem: Move ncdevmem under drivers/net/hw Stanislav Fomichev
2024-10-03  7:29   ` Mina Almasry
2024-10-03 17:25     ` Stanislav Fomichev [this message]
2024-10-03 19:16       ` Mina Almasry
2024-09-30 17:17 ` [PATCH net-next v2 12/12] selftests: ncdevmem: Add automated test Stanislav Fomichev
2024-10-03  7:39   ` Mina Almasry
2024-10-03 17:47     ` Stanislav Fomichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zv7TpwAgpVs2SjyH@mini-arch \
    --to=stfomichev@gmail.com \
    --cc=almasrymina@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.