All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Dipendra Khadka <kdipendra88@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix  dereferencing freed memory 'fw'
Date: Mon, 23 Sep 2024 11:35:32 +0300	[thread overview]
Message-ID: <ZvEoVC_j6jdBhvim@kuha.fi.intel.com> (raw)
In-Reply-To: <20240922105212.28099-1-kdipendra88@gmail.com>

On Sun, Sep 22, 2024 at 10:52:11AM +0000, Dipendra Khadka wrote:
> smatch reported dereferencing freed memory as below:
> '''
> drivers/usb/typec/tipd/core.c:1196 tps6598x_apply_patch() error: dereferencing freed memory 'fw'
> '''

This is only my opinion, but I don't like those '''single triple
quotes''' in commit messages - they are just confusing. You don't need
to use any kind of quotation marks in cases like this IMO.

thanks,

-- 
heikki

  parent reply	other threads:[~2024-09-23  8:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-22 10:52 [PATCH] Fix dereferencing freed memory 'fw' Dipendra Khadka
2024-09-23  8:20 ` Heikki Krogerus
2024-09-23  8:35 ` Heikki Krogerus [this message]
2024-09-23  8:45   ` Dipendra Khadka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvEoVC_j6jdBhvim@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kdipendra88@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.