From: Jiri Olsa <olsajiri@gmail.com>
To: Tony Ambardar <tony.ambardar@gmail.com>
Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Viktor Malik <vmalik@redhat.com>
Subject: Re: [PATCH bpf-next v1 0/3] Improve .BTF_ids patching and alignment
Date: Mon, 23 Sep 2024 13:07:07 +0200 [thread overview]
Message-ID: <ZvFL2_qf3m6jcnqu@krava> (raw)
In-Reply-To: <cover.1726806756.git.tony.ambardar@gmail.com>
On Fri, Sep 20, 2024 at 12:49:10AM -0700, Tony Ambardar wrote:
> Hello all,
>
> This patch series offers improvements to the way .BTF_ids section data is
> created and later patched by resolve_btfids.
>
> Patch #1 simplifies the byte-order translation in resolve_btfids while
> making it more resilient to future .BTF_ids encoding updates.
>
> Patch #2 makes sure all BTF ID data is 4-byte aligned, and not only the
> .BTF_ids used for vmlinux.
>
> Patch #3 syncs the above changes in btf_ids.h to tools/include, obviating
> a previous alignment fix in selftests/bpf.
>
> Feedback and suggestions are welcome!
>
> Best regards,
> Tony
nice, thanks for the fix
Jean-Philippe, Viktor,
any chance you could check/test this patchset? it changes your recent
cross building fixes
thanks,
jirka
>
>
> Tony Ambardar (3):
> tools/resolve_btfids: Simplify handling cross-endian compilation
> bpf: btf: Ensure natural alignment of .BTF_ids section
> tools/bpf, selftests/bpf : Sync btf_ids.h to tools
>
> include/linux/btf_ids.h | 1 +
> tools/bpf/resolve_btfids/main.c | 60 +++++---------
> tools/include/linux/btf_ids.h | 80 +++++++++++++++++--
> .../selftests/bpf/prog_tests/resolve_btfids.c | 6 --
> 4 files changed, 97 insertions(+), 50 deletions(-)
>
> --
> 2.34.1
>
prev parent reply other threads:[~2024-09-23 11:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 7:49 [PATCH bpf-next v1 0/3] Improve .BTF_ids patching and alignment Tony Ambardar
2024-09-20 7:49 ` [PATCH bpf-next v1 1/3] tools/resolve_btfids: Simplify handling cross-endian compilation Tony Ambardar
2024-09-21 9:38 ` Eduard Zingerman
2024-09-23 10:55 ` Jiri Olsa
2024-10-14 12:56 ` Viktor Malik
2024-09-20 7:49 ` [PATCH bpf-next v1 2/3] bpf: btf: Ensure natural alignment of .BTF_ids section Tony Ambardar
2024-09-21 9:46 ` Eduard Zingerman
2024-09-23 10:54 ` Jiri Olsa
2024-09-23 11:39 ` Eduard Zingerman
2024-09-20 7:49 ` [PATCH bpf-next v1 3/3] tools/bpf, selftests/bpf : Sync btf_ids.h to tools Tony Ambardar
2024-09-23 11:07 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvFL2_qf3m6jcnqu@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=jean-philippe@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tony.ambardar@gmail.com \
--cc=vmalik@redhat.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.