From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, "Song Gao" <gaosong@loongson.cn>,
"Peter Xu" <peterx@redhat.com>, "Bin Meng" <bmeng.cn@gmail.com>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Hyman Huang" <yong.huang@smartx.com>,
"Klaus Jensen" <its@irrelevant.dk>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"John Snow" <jsnow@redhat.com>,
"Jesper Devantier" <foss@defmacro.it>,
"Bin Meng" <bin.meng@windriver.com>, "Greg Kurz" <groug@kaod.org>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Yuval Shaia" <yuval.shaia.ml@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@yandex-team.ru>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Fabiano Rosas" <farosas@suse.de>,
"Keith Busch" <kbusch@kernel.org>,
"Eric Blake" <eblake@redhat.com>,
qemu-block@nongnu.org, "Kevin Wolf" <kwolf@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Gerd Hoffmann" <kraxel@redhat.com>, "Fam Zheng" <fam@euphon.net>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>
Subject: Re: [PATCH v2 00/22] -Werror=maybe-uninitialized fixes
Date: Tue, 24 Sep 2024 15:08:35 +0200 [thread overview]
Message-ID: <ZvK502GDuPV7jGUl@redhat.com> (raw)
In-Reply-To: <20240924130554.749278-1-marcandre.lureau@redhat.com>
On Tue, Sep 24, 2024 at 05:05:31PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Hi,
>
> Depending on -Doptimization=<value>, GCC (14.2.1 here) produces different
> maybe-uninitialized warnings:
> - g: produces -Werror=maybe-uninitialized errors
> - 0: clean build
> - 1: produces -Werror=maybe-uninitialized errors
> - 2: clean build
> - 3: produces few -Werror=maybe-uninitialized errors
> - s: produces -Werror=maybe-uninitialized errors
>
> Most are false-positive, because prior LOCK_GUARD should guarantee an
> initialization path. Few of them are a bit trickier. Finally, I found
> a potential related memory leak.
In addition we now build with "-ftrivial-auto-var-init=zero", so
any case which is missing an "= NULL" or "= 0" initialization is
protected.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-09-24 13:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 13:05 [PATCH v2 00/22] -Werror=maybe-uninitialized fixes marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 01/22] util/coroutine: fix -Werror=maybe-uninitialized false-positive marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 02/22] util/timer: " marcandre.lureau
2024-09-26 4:39 ` Manos Pitsidianakis
2024-09-24 13:05 ` [PATCH v2 03/22] hw/qxl: fix -Werror=maybe-uninitialized false-positives marcandre.lureau
2024-09-26 4:40 ` Manos Pitsidianakis
2024-09-24 13:05 ` [PATCH v2 04/22] nbd: fix -Werror=maybe-uninitialized false-positive marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 05/22] block/mirror: " marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 06/22] " marcandre.lureau
2024-09-26 4:45 ` Manos Pitsidianakis
2024-09-24 13:05 ` [PATCH v2 07/22] block/stream: fix -Werror=maybe-uninitialized false-positives marcandre.lureau
2024-09-26 4:50 ` Manos Pitsidianakis
2024-09-24 13:05 ` [PATCH v2 08/22] hw/ahci: fix -Werror=maybe-uninitialized false-positive marcandre.lureau
2024-09-26 4:52 ` Manos Pitsidianakis
2024-09-24 13:05 ` [PATCH v2 09/22] hw/vhost-scsi: fix -Werror=maybe-uninitialized marcandre.lureau
2024-09-25 7:57 ` Stefano Garzarella
2024-09-24 13:05 ` [PATCH v2 10/22] hw/sdhci: fix -Werror=maybe-uninitialized false-positive marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 11/22] block/block-copy: " marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 12/22] migration: fix -Werror=maybe-uninitialized false-positives marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 13/22] hw/virtio-blk: fix -Werror=maybe-uninitialized false-positive marcandre.lureau
2024-09-25 7:59 ` Stefano Garzarella
2024-09-24 13:05 ` [PATCH v2 14/22] migration: " marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 15/22] linux-user/hppa: " marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 16/22] target/loongarch: " marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 17/22] tests: " marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 18/22] hw/virtio: " marcandre.lureau
2024-09-25 8:07 ` Stefano Garzarella
2024-09-27 13:07 ` Eugenio Perez Martin
2024-09-30 8:11 ` Stefano Garzarella
2024-09-30 8:30 ` Eugenio Perez Martin
2024-09-27 13:04 ` Eugenio Perez Martin
2024-09-30 8:08 ` Stefano Garzarella
2024-09-24 13:05 ` [PATCH v2 19/22] block: " marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 20/22] qom/object: fix -Werror=maybe-uninitialized marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 21/22] fsdep/9p: fix -Werror=maybe-uninitialized false-positive marcandre.lureau
2024-09-24 13:05 ` [PATCH v2 22/22] RFC: hw/virtio: a potential leak fix marcandre.lureau
2024-09-25 8:18 ` Stefano Garzarella
2024-09-24 13:08 ` Daniel P. Berrangé [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-09-24 13:01 [PATCH v2 00/22] -Werror=maybe-uninitialized fixes marcandre.lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvK502GDuPV7jGUl@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bin.meng@windriver.com \
--cc=bmeng.cn@gmail.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=eperezma@redhat.com \
--cc=erdnaxe@crans.org \
--cc=fam@euphon.net \
--cc=farosas@suse.de \
--cc=foss@defmacro.it \
--cc=gaosong@loongson.cn \
--cc=groug@kaod.org \
--cc=hreitz@redhat.com \
--cc=its@irrelevant.dk \
--cc=jsnow@redhat.com \
--cc=kbusch@kernel.org \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=laurent@vivier.eu \
--cc=ma.mandourr@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@yandex-team.ru \
--cc=yong.huang@smartx.com \
--cc=yuval.shaia.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.