All of lore.kernel.org
 help / color / mirror / Atom feed
From: shejialuo <shejialuo@gmail.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, "Ronan Pigott" <ronan@rjp.ie>,
	"René Scharfe" <l.s.r@web.de>
Subject: Re: [PATCH 0/2] config: fix evaluating "onbranch" with nonexistent git dir
Date: Tue, 24 Sep 2024 22:20:26 +0800	[thread overview]
Message-ID: <ZvLKqujqfDFxCtBp@ArchLinux> (raw)
In-Reply-To: <cover.1727171197.git.ps@pks.im>

On Tue, Sep 24, 2024 at 12:05:37PM +0200, Patrick Steinhardt wrote:
> Hi,
> 
> this small patch series fixes evaluating "includeIf.onbranch" conditions
> when running outside of a repository with an invalid gitdir.
> 
> Thanks!
> 
> Patrick
> 
> Patrick Steinhardt (2):
>   t1305: exercise edge cases of "onbranch" includes
>   config: fix evaluating "onbranch" with nonexistent git dir
> 
>  config.c                  | 15 +++++++++------
>  t/t1305-config-include.sh | 40 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 49 insertions(+), 6 deletions(-)
> 
> -- 
> 2.46.0.551.gc5ee8f2d1c.dirty
> 

Although I comment a lot in [PATCH 2/2], I think this series is good
enough. The reason why I comment on [PATCH 2/2] is I think we should
enhance this behavior in the future.

Thanks,
Jialuo

      parent reply	other threads:[~2024-09-24 14:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20 17:37 BUG: refs.c:1933: reference backend is unknown Ronan Pigott
2024-09-21 16:09 ` shejialuo
2024-09-21 18:06   ` Ronan Pigott
2024-09-21 21:22     ` René Scharfe
2024-09-22  6:51       ` shejialuo
2024-09-22 14:41         ` shejialuo
2024-09-24 10:05 ` [PATCH 0/2] config: fix evaluating "onbranch" with nonexistent git dir Patrick Steinhardt
2024-09-24 10:05   ` [PATCH 1/2] t1305: exercise edge cases of "onbranch" includes Patrick Steinhardt
2024-09-24 16:05     ` Junio C Hamano
2024-09-24 10:05   ` [PATCH 2/2] config: fix evaluating "onbranch" with nonexistent git dir Patrick Steinhardt
2024-09-24 14:11     ` shejialuo
2024-09-24 16:17     ` Junio C Hamano
2024-09-24 14:20   ` shejialuo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvLKqujqfDFxCtBp@ArchLinux \
    --to=shejialuo@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=ps@pks.im \
    --cc=ronan@rjp.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.