From: Qianqiang Liu <qianqiang.liu@163.com>
To: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
syzbot+3d613ae53c031502687a@syzkaller.appspotmail.com
Subject: [PATCH v2] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs
Date: Wed, 25 Sep 2024 00:13:06 +0800 [thread overview]
Message-ID: <ZvLlEpIMQnJcJsla@thinkpad> (raw)
In-Reply-To: <a57734e8-ffb9-4af1-be02-eb0c99507048@gmx.de>
syzbot has found a NULL pointer dereference bug in fbcon.
This issue is caused by ops->putcs being a NULL pointer.
We need to ensure it is initialized properly.
Reported-by: syzbot+3d613ae53c031502687a@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=3d613ae53c031502687a
Tested-by: syzbot+3d613ae53c031502687a@syzkaller.appspotmail.com
Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com>
---
Changes since v1:
- Initialize ops->putcs by calling set_blitting_type()
---
drivers/video/fbdev/core/fbcon.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 2e093535884b..d9abae2516d8 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -861,6 +861,8 @@ static int set_con2fb_map(int unit, int newidx, int user)
return err;
fbcon_add_cursor_work(info);
+ } else if (vc) {
+ set_blitting_type(vc, info);
}
con2fb_map[unit] = newidx;
--
2.34.1
next prev parent reply other threads:[~2024-09-24 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 1:10 [PATCH] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs Qianqiang Liu
2024-09-17 6:25 ` Helge Deller
2024-09-20 15:30 ` Qianqiang Liu
2024-09-24 16:13 ` Qianqiang Liu [this message]
2024-09-24 16:59 ` [PATCH v2] " Helge Deller
2024-09-25 5:29 ` [PATCH v3] " Qianqiang Liu
2024-09-25 19:33 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvLlEpIMQnJcJsla@thinkpad \
--to=qianqiang.liu@163.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+3d613ae53c031502687a@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.