From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 6/6] x86/alternative: build time check feature is in range
Date: Wed, 25 Sep 2024 11:23:58 +0200 [thread overview]
Message-ID: <ZvPWroluMNzSG0yU@macbook.local> (raw)
In-Reply-To: <b34e0580-e5e1-48cd-94b3-f685562447fd@suse.com>
On Wed, Sep 25, 2024 at 11:04:45AM +0200, Jan Beulich wrote:
> On 25.09.2024 10:42, Roger Pau Monne wrote:
> > Ensure at build time the feature(s) used for the alternative blocks are in
> > range of the featureset.
> >
> > No functional change intended, as all current usages are correct.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>
> I'm struggling with what this is meant to guard against. All validly usable
> constants are within range. Any unsuitable constant can of course have any
> value, yet you'd then refuse only those which are out of bounds.
It's IMO better than nothing, and it's a build-time check.
Thanks, Roger.
prev parent reply other threads:[~2024-09-25 9:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 8:42 [PATCH v2 0/6] xen/livepatch: improvements to loading Roger Pau Monne
2024-09-25 8:42 ` [PATCH v2 1/6] xen/livepatch: remove useless check for duplicated sections Roger Pau Monne
2024-09-25 8:52 ` Jan Beulich
2024-09-25 9:21 ` Roger Pau Monné
2024-09-25 9:29 ` Andrew Cooper
2024-09-25 8:42 ` [PATCH v2 2/6] xen/livepatch: zero pointer to temporary load buffer Roger Pau Monne
2024-09-25 9:33 ` Andrew Cooper
2024-09-25 10:00 ` Roger Pau Monné
2024-09-25 18:28 ` Andrew Cooper
2024-09-26 7:06 ` Roger Pau Monné
2024-09-26 8:22 ` Roger Pau Monné
2024-09-26 8:24 ` Andrew Cooper
2024-09-26 8:36 ` Roger Pau Monné
2024-09-25 8:42 ` [PATCH v2 3/6] xen/livepatch: simplify and unify logic in prepare_payload() Roger Pau Monne
2024-09-25 9:37 ` Andrew Cooper
2024-09-25 10:02 ` Roger Pau Monné
2024-09-25 8:42 ` [PATCH v2 4/6] xen/livepatch: do Xen build-id check earlier Roger Pau Monne
2024-09-25 10:21 ` Andrew Cooper
2024-09-25 13:39 ` Roger Pau Monné
2024-09-25 8:42 ` [PATCH v2 5/6] x86/alternatives: do not BUG during apply Roger Pau Monne
2024-09-25 9:01 ` Jan Beulich
2024-09-25 9:28 ` Roger Pau Monné
2024-09-25 10:02 ` Jan Beulich
2024-09-25 10:25 ` Andrew Cooper
2024-09-25 10:53 ` Andrew Cooper
2024-09-25 13:55 ` Roger Pau Monné
2024-09-25 8:42 ` [PATCH v2 6/6] x86/alternative: build time check feature is in range Roger Pau Monne
2024-09-25 8:51 ` Andrew Cooper
2024-09-25 9:24 ` Roger Pau Monné
2024-09-25 9:04 ` Jan Beulich
2024-09-25 9:23 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvPWroluMNzSG0yU@macbook.local \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.