From: Andi Kleen <ak@linux.intel.com>
To: Yeo Reum Yun <YeoReum.Yun@arm.com>
Cc: "peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"acme@kernel.org" <acme@kernel.org>,
"namhyung@kernel.org" <namhyung@kernel.org>,
Mark Rutland <Mark.Rutland@arm.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"irogers@google.com" <irogers@google.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"james.clark@linaro.org" <james.clark@linaro.org>,
"howardchu95@gmail.com" <howardchu95@gmail.com>, nd <nd@arm.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/2] perf stat: Close cork_fd when create_perf_stat_counter() failed
Date: Wed, 25 Sep 2024 06:17:59 -0700 [thread overview]
Message-ID: <ZvQNh36COIpoOptw@tassilo> (raw)
In-Reply-To: <GV1PR08MB10521644365A907A4301AABE9FB692@GV1PR08MB10521.eurprd08.prod.outlook.com>
On Wed, Sep 25, 2024 at 12:40:44PM +0000, Yeo Reum Yun wrote:
> Hi Andi,
>
> > Technically 0 is a valid file descriptor. Check for >= 0
>
> Right. However, when I see the event, evlist__start_workload(),
> it checks cork_fd with
>
> if (evlist->workload.cork_fd > 0) {
>
> Would you like to change this with this patchset too?
Yes please.
-Andi
next prev parent reply other threads:[~2024-09-25 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 11:08 [PATCH v5 0/2] Minor fixes error handling of perf stat Levi Yun
2024-09-25 11:08 ` [PATCH v5 1/2] perf stat: Close cork_fd when create_perf_stat_counter() failed Levi Yun
2024-09-25 12:15 ` Andi Kleen
2024-09-25 12:40 ` Yeo Reum Yun
2024-09-25 13:17 ` Andi Kleen [this message]
2024-09-25 11:08 ` [PATCH v5 2/2] perf stat: Stop repeating when ref_perf_stat() returns -1 Levi Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvQNh36COIpoOptw@tassilo \
--to=ak@linux.intel.com \
--cc=Mark.Rutland@arm.com \
--cc=YeoReum.Yun@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=howardchu95@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nd@arm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.