From: Joe Damato <jdamato@fastly.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, Willem de Bruijn <willemb@google.com>,
Jonathan Davies <jonathan.davies@nutanix.com>,
eric.dumazet@gmail.com
Subject: Re: [PATCH net 2/2] net: add more sanity checks to qdisc_pkt_len_init()
Date: Wed, 25 Sep 2024 10:51:57 -0700 [thread overview]
Message-ID: <ZvRNvTdnCxzeXmse@LQ3V64L9R2> (raw)
In-Reply-To: <20240924150257.1059524-3-edumazet@google.com>
On Tue, Sep 24, 2024 at 03:02:57PM +0000, Eric Dumazet wrote:
> One path takes care of SKB_GSO_DODGY, assuming
> skb->len is bigger than hdr_len.
My only comment, which you may feel free to ignore, is that we've
recently merged a change to replace the term 'sanity check' in the
code [1].
Given that work is being done to replace terminology in the source
code, I am wondering if that same ruling applies to commit messages.
If so, perhaps the title of this commit can be adjusted?
[1]: https://lore.kernel.org/netdev/20240912171446.12854-1-stephen@networkplumber.org/
next prev parent reply other threads:[~2024-09-25 17:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 15:02 [PATCH net 0/2] net: two fixes for qdisc_pkt_len_init() Eric Dumazet
2024-09-24 15:02 ` [PATCH net 1/2] net: avoid potential underflow in qdisc_pkt_len_init() with UFO Eric Dumazet
2024-09-26 9:07 ` Willem de Bruijn
2024-09-26 18:00 ` Jonathan Davies
2024-09-24 15:02 ` [PATCH net 2/2] net: add more sanity checks to qdisc_pkt_len_init() Eric Dumazet
2024-09-25 17:51 ` Joe Damato [this message]
2024-09-25 18:00 ` Eric Dumazet
2024-09-25 18:24 ` Joe Damato
2024-09-25 18:27 ` Stephen Hemminger
2024-09-25 18:55 ` Eric Dumazet
2024-09-25 19:01 ` Eric Dumazet
2024-09-25 19:15 ` Joe Damato
2024-09-25 19:07 ` Joe Damato
2024-09-25 19:08 ` Eric Dumazet
2024-09-26 9:13 ` Willem de Bruijn
2024-09-26 9:17 ` Willem de Bruijn
2024-09-26 9:19 ` Eric Dumazet
2024-10-01 9:57 ` Paolo Abeni
2024-09-26 2:26 ` [PATCH net 0/2] net: two fixes for qdisc_pkt_len_init() David Ahern
2024-10-01 10:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvRNvTdnCxzeXmse@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jonathan.davies@nutanix.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.