From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Anthony PERARD <anthony.perard@vates.tech>
Cc: xen-devel@lists.xenproject.org, Paul Durrant <paul@xen.org>,
Owen Smith <owen.smith@cloud.com>,
Mark Syms <mark.syms@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v3] blkif: reconcile protocol specification with in-use implementations
Date: Thu, 26 Sep 2024 13:08:34 +0200 [thread overview]
Message-ID: <ZvVAssngeL5vPrDg@macbook.local> (raw)
In-Reply-To: <ZvUtgqY4gWGS0I8K@l14>
On Thu, Sep 26, 2024 at 09:46:43AM +0000, Anthony PERARD wrote:
> On Thu, Sep 12, 2024 at 11:57:29AM +0200, Roger Pau Monne wrote:
> > /*
> > * Cast to this structure when blkif_request.operation == BLKIF_OP_DISCARD
> > * sizeof(struct blkif_request_discard) <= sizeof(struct blkif_request)
> > + *
> > + * The 'sector_number' field is in units of 512b, despite the value of the
> > + * 'sector-size' xenstore node. Note however that the offset in
> > + * 'sector_number' must be aligned to 'sector-size'.
>
> For discard request, there's "discard-granularity", and I think
> `sector_number` should be aligned to it. See "discard-granularity" and
> note 4.
Indeed, the wording here would be better as:
"Note however that the offset in 'sector_number' must be aligned to
'sector-size' or 'discard-alignment' if present."
Would you mind sending a patch to fix this?
Thanks, Roger.
prev parent reply other threads:[~2024-09-26 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 9:57 [PATCH v3] blkif: reconcile protocol specification with in-use implementations Roger Pau Monne
2024-09-12 12:06 ` Jan Beulich
2024-09-12 12:50 ` Roger Pau Monné
2024-09-12 12:55 ` Andrew Cooper
2024-09-26 9:46 ` Anthony PERARD
2024-09-26 11:08 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvVAssngeL5vPrDg@macbook.local \
--to=roger.pau@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=jgross@suse.com \
--cc=mark.syms@citrix.com \
--cc=owen.smith@cloud.com \
--cc=paul@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.