From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B00078C90; Thu, 26 Sep 2024 12:12:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727352757; cv=none; b=Ellv1PLUQvtvoL3tvXlT8nokDZLH3mf4PMHMt/WaRBrwQKN6kRxTkxoJ+tR237xgTOrtkenzqMxBwk7I2mfUz3AG3gp/UVu65kzSnrmKMjDnt2l5BR/vkUysek3VAh5BVtyMXzJrTrI2f4eSQn2UuzPN4TwZ9HVOmOhmkFz+a/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727352757; c=relaxed/simple; bh=3f2PlrxlmtzV9bX8QaJPEWHju7M5P+yDbVSMqF02t3g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fSWcxx+Ba0l8EC0gIPO3I7hEr4VWUElZtfY+j8wMDkCwVFo7Odw3tpZXratFFVOTw9T6KwkEbt/Sb26loiuxjsJLE7snToVamXAF/gUZOZWlzAgU9qhAj9l63me6n7bdu9oIRTZikqMTV4beCVWHdYEyG27/XudQSd9xAZX/Ju0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bS6C7Ne0; arc=none smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bS6C7Ne0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727352755; x=1758888755; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3f2PlrxlmtzV9bX8QaJPEWHju7M5P+yDbVSMqF02t3g=; b=bS6C7Ne0padragF3UhIWDYjKNJnalKjFNKM7gE6LYsWBRGh0m5zhGE0T HCnwK2+BVpVvYDPmlhkMya7BGdxlS3469EV7PA/mzbvRK/x3qRjKkDhC8 8h2qbR7zzijalIfXP0ZkmbsouBrbrvLqzjA+j7qtsDh8kMWvlJ8o6NVfW gnTrGMQXpHPNkqTLDwoe1zZCKNPb6+n6I697trpMkl4m8phMAt8BMIxI3 4IdQLC5qsmdI3pS+bfBozlyn4a+8zWmczv+vHlew3y2pP34vG98VdD5Od Mb5dESoYx1h1ejZK5oPNzIYu5VX+0QL13VFSYfQc9GyDUPPrLA90yuU6M g==; X-CSE-ConnectionGUID: 42oz2T67T92UjghuArd4cQ== X-CSE-MsgGUID: jf5arXABTRa8jEt1TPLGQA== X-IronPort-AV: E=McAfee;i="6700,10204,11206"; a="26579854" X-IronPort-AV: E=Sophos;i="6.11,155,1725346800"; d="scan'208";a="26579854" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2024 05:12:10 -0700 X-CSE-ConnectionGUID: XUaBbbtrQf+w9SVZVGuJPQ== X-CSE-MsgGUID: 6uWSaNQUTgaXk7bdCwqo8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,155,1725346800"; d="scan'208";a="77050081" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2024 05:12:08 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1stnLo-0000000DBma-1Xhj; Thu, 26 Sep 2024 15:12:04 +0300 Date: Thu, 26 Sep 2024 15:12:04 +0300 From: Andy Shevchenko To: Dmitry Baryshkov Cc: Markus Elfring , linux-usb@vger.kernel.org, Ajay Gupta , Greg Kroah-Hartman , Haotien Hsu , Heikki Krogerus , Utkarsh Patel , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wolfram Sang , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 0/2] usb: typec: ucsi: ccg: Adjustments for common code in two functions Message-ID: References: Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Sep 26, 2024 at 12:26:24AM +0300, Dmitry Baryshkov wrote: > On Wed, Sep 25, 2024 at 07:31:04PM GMT, Markus Elfring wrote: > > From: Markus Elfring > > Date: Wed, 25 Sep 2024 19:19:01 +0200 > > > > A few update suggestions were taken into account > > from static source code analysis. > > > > Markus Elfring (2): > > Use common code in ccg_write() > > Use common code in ccg_read() > > > > drivers/usb/typec/ucsi/ucsi_ccg.c | 15 ++++++++------- > > 1 file changed, 8 insertions(+), 7 deletions(-) > > For the series: > > Acked-by: Dmitry Baryshkov I believe there is no-one to take it, but in any case the thing is that kfree() probably can be done using __free(). Then PM runtime handled differently. -- With Best Regards, Andy Shevchenko