Re: [PATCH] drm: Print bad EDID notices only once

[Andi Kleen <ak@linux.intel.com>]

On Thu, Sep 26, 2024 at 03:51:09PM +0200, Maxime Ripard wrote:
> Hi,
> 
> On Thu, Sep 26, 2024 at 06:32:53AM GMT, Andi Kleen wrote:
> > I have an old monitor that reports a zero EDID block, which results in a
> > warning message. This happens on every screen save cycle, and maybe in
> > some other situations, and over time the whole kernel log gets filled
> > with these redundant messages. Printing it only once should be
> > sufficient.
> > 
> > Mark all the bad EDID notices as _once.
> 
> Is it?
> 
> I mean, it probably is if you connect and reconnect the same display,
> but if it's two different then the second definitely has value.

If the first display had a good (or differently corrupted) EDID block the
second bad one would still be printed. The case where you don't see anything
is if you connect two different displays with the same kind of EDID corruption.

I'm not sure if that is actually actionable in any way. I certainly
have no idea what I would do with it.

But I think what you're suggesting is to include some identifier per
monitor, but I'm not aware of anything that would work here because
if the EDID block is bad there is nothing that is intelligible to
the user. Including the device like it was suggested earlier also
wouldn't help because it is tied to the connector, not the monitor.

In the end it's a trade off between a dubious benefit versus
a significant down side (flooding logs).

-Andi