From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2950D1494AC; Thu, 26 Sep 2024 19:36:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727379401; cv=none; b=Rn4KCLbLgfi1Q56+9vhqBnvuwI3VmUUEtR1fsAHQFeK1BHJSjZyTwIry2fHHoELWqcklz0s/KBAVLet5o+nqG5egzlKyZq9ZfdG4qm3t1otgGxuFAWAPSmGG0xQzYVqUeEClBbdkxMElgXT/RMzV/n0VZG6nIpPIf4596kYUFFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727379401; c=relaxed/simple; bh=oTuLsTpIYngovcwg7oYGP5Q1cLZWPqjxspwWVgIi7Qk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NauvVpAvEkOrDu3S2OXoHARop2CohlzT/QRvEYGikHeHZK0MxB9K5QOxAxJasQGIv9gFRHlKBS7Ys2EfxY0j1zx7E+RUIq8lVHbfaa5F2Cq4HIhopkmTBUz38E7PpuY9+C+ycQwmjMQZ5x4MKjjtHuHGr2FNvF9KqxqCrkTyZKk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rLTUHVDt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rLTUHVDt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FA12C4CEC5; Thu, 26 Sep 2024 19:36:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727379400; bh=oTuLsTpIYngovcwg7oYGP5Q1cLZWPqjxspwWVgIi7Qk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rLTUHVDty+aEQz35kBNbSRuF/AX9cUFnADCjyKTTL6Bzdf4PmTrDRW94Z4yHEvUjj j6bG3bj1ibIgmQH9+B/brTAIqAm2YmvjRW8scv0exY5A7ZN2GEZgbgTz0jIfgSpTSk JsE58rwx5v1BqqJLM4yarr1/cd33a7tEIAI2Y7ZNxYBPBSbWJq/ZSqWw3Q8eyeVpIx aneIRdjJbER+VKcm5XZt2OOucarivqNW8tojwDBmi14VfXjnKSpZoAFMBLRxkW/Uqv tCczGflKotXBW9y5pRjwgVvnYaa04kCB7DKY+UPOAW32iasPKC4xuhoO9zBo5euZHP k669FYI+f9kNw== Date: Thu, 26 Sep 2024 12:36:37 -0700 From: Namhyung Kim To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nick Terrell , Guilherme Amadio , Changbin Du , "Steinar H. Gunderson" , "Masami Hiramatsu (Google)" , Aditya Gupta , Athira Rajeev , Masahiro Yamada , Huacai Chen , Bibo Mao , Kajol Jain , Anup Patel , Shenlin Liang , Atish Patra , Oliver Upton , Chen Pei , Dima Kogan , Alexander Lobakin , "David S. Miller" , Przemek Kitszel , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Yang Jihong Subject: Re: [PATCH v1 09/11] perf build: Rename HAVE_DWARF_SUPPORT to HAVE_LIBDW_SUPPORT Message-ID: References: <20240924160418.1391100-1-irogers@google.com> <20240924160418.1391100-10-irogers@google.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Sep 26, 2024 at 08:10:04AM -0700, Ian Rogers wrote: > On Wed, Sep 25, 2024 at 5:34 PM Namhyung Kim wrote: > > > > On Tue, Sep 24, 2024 at 09:04:16AM -0700, Ian Rogers wrote: > > > In Makefile.config for unwinding the name dwarf implies either > > > libunwind or libdw. Make it clearer that HAVE_DWARF_SUPPORT is really > > > just defined when libdw is present by renaming to HAVE_LIBDW_SUPPORT. > > > > > > Signed-off-by: Ian Rogers > > > --- > > > tools/perf/Documentation/perf-check.txt | 6 +++--- > > > tools/perf/Makefile.config | 2 +- > > > tools/perf/arch/powerpc/annotate/instructions.c | 4 ++-- > > > tools/perf/arch/x86/annotate/instructions.c | 2 +- > > > tools/perf/builtin-annotate.c | 2 +- > > > tools/perf/builtin-check.c | 6 +++--- > > > tools/perf/builtin-probe.c | 12 ++++++------ > > > tools/perf/builtin-report.c | 4 ++-- > > > tools/perf/util/annotate-data.h | 8 ++++---- > > > tools/perf/util/debuginfo.h | 6 +++--- > > > tools/perf/util/disasm.c | 4 ++-- > > > tools/perf/util/disasm.h | 4 ++-- > > > tools/perf/util/genelf.c | 4 ++-- > > > tools/perf/util/genelf.h | 2 +- > > > tools/perf/util/include/dwarf-regs.h | 6 +++--- > > > tools/perf/util/probe-event.c | 4 ++-- > > > tools/perf/util/probe-finder.h | 4 ++-- > > > 17 files changed, 40 insertions(+), 40 deletions(-) > > > > > > diff --git a/tools/perf/Documentation/perf-check.txt b/tools/perf/Documentation/perf-check.txt > > > index 45101a8e4154..31741499e786 100644 > > > --- a/tools/perf/Documentation/perf-check.txt > > > +++ b/tools/perf/Documentation/perf-check.txt > > > @@ -47,15 +47,15 @@ feature:: > > > bpf / HAVE_LIBBPF_SUPPORT > > > bpf_skeletons / HAVE_BPF_SKEL > > > debuginfod / HAVE_DEBUGINFOD_SUPPORT > > > - dwarf / HAVE_DWARF_SUPPORT > > > - dwarf_getlocations / HAVE_DWARF_SUPPORT > > > + dwarf / HAVE_LIBDW_SUPPORT > > > + dwarf_getlocations / HAVE_LIBDW_SUPPORT > > > > I'm not sure if we really want to display dwarf_getlocatiosn as it's too > > implementation detail IMHO. Maybe just 'dwarf' or 'libdw' is enough. > > I think that's follow up work. I think we should rename dwarf to libdw > given the confusion using dwarf here can create. Ok, agreed. Thanks, Namhyung > > > > > dwarf-unwind / HAVE_DWARF_UNWIND_SUPPORT > > > auxtrace / HAVE_AUXTRACE_SUPPORT > > > libaudit / HAVE_LIBAUDIT_SUPPORT > > > libbfd / HAVE_LIBBFD_SUPPORT > > > libcapstone / HAVE_LIBCAPSTONE_SUPPORT > > > libcrypto / HAVE_LIBCRYPTO_SUPPORT > > > - libdw-dwarf-unwind / HAVE_DWARF_SUPPORT > > > + libdw-dwarf-unwind / HAVE_LIBDW_SUPPORT > > > libelf / HAVE_LIBELF_SUPPORT > > > libnuma / HAVE_LIBNUMA_SUPPORT > > > libopencsd / HAVE_CSTRACE_SUPPORT