All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Duncan Roe <duncan_roe@optusnet.com.au>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH libnetfilter_queue] build: add missing backslash to build_man.sh
Date: Fri, 4 Oct 2024 15:18:28 +0200	[thread overview]
Message-ID: <Zv_rJM6_dyCVA7KU@orbyte.nwl.cc> (raw)
In-Reply-To: <20241004040639.14989-1-duncan_roe@optusnet.com.au>

Hi Duncan,

On Fri, Oct 04, 2024 at 02:06:39PM +1000, Duncan Roe wrote:
> Search for exact match of ".RI" had a '\' to escape '.' from the regexp
> parser but was missing another '\' to escape the 1st '\' from shell.
> Had not yet caused a problem but might as well do things correctly.

Your patch looks correct and bash(1) confirms the need for escaping:

"If any part of word is quoted, the delimiter is the result of quote
removal on word, and the lines in the here-document are not expanded. If
word is unquoted, all lines of the here-document are subjected to
parameter expansion, command substitution, and arithmetic expansion, the
character sequence \<newline> is ignored, and \ must be used to quote
the characters \, $, and `."

This holds another interesting detail, though: By quoting your
delimiter, you may disable expansion entirely which might improve
readability in those ed commands?

Cheers, Phil

  reply	other threads:[~2024-10-04 13:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04  4:06 [PATCH libnetfilter_queue] build: add missing backslash to build_man.sh Duncan Roe
2024-10-04 13:18 ` Phil Sutter [this message]
2024-10-06 23:52   ` Duncan Roe
2024-10-07 12:24     ` Phil Sutter
2024-10-07 22:50       ` Duncan Roe
2024-10-12  4:08       ` Duncan Roe
2024-10-12 10:31 ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zv_rJM6_dyCVA7KU@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=duncan_roe@optusnet.com.au \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.