From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, eric.dumazet@gmail.com,
syzbot <syzkaller@googlegroups.com>
Subject: Re: [PATCH nf] netfilter: nf_tables: prevent nf_skb_duplicated corruption
Date: Fri, 27 Sep 2024 13:57:43 +0200 [thread overview]
Message-ID: <Zvadt0P6TDZwELej@calendula> (raw)
In-Reply-To: <20240926185611.3988042-1-edumazet@google.com>
On Thu, Sep 26, 2024 at 06:56:11PM +0000, Eric Dumazet wrote:
> syzbot found that nf_dup_ipv4() or nf_dup_ipv6() could write
> per-cpu variable nf_skb_duplicated in an unsafe way [1].
>
> Disabling preemption as hinted by the splat is not enough,
> we have to disable soft interrupts as well.
Applied, thanks
prev parent reply other threads:[~2024-09-27 11:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 18:56 [PATCH nf] netfilter: nf_tables: prevent nf_skb_duplicated corruption Eric Dumazet
2024-09-27 11:57 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zvadt0P6TDZwELej@calendula \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.