From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Willy Tarreau <w@1wt.eu>,
dwarves@vger.kernel.org, Alan Maguire <alan.maguire@oracle.com>,
Jiri Olsa <jolsa@kernel.org>,
Clark Williams <williams@redhat.com>,
Kate Carcia <kcarcia@redhat.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: Re: [PATCH 0/2] --padding option to combine with --with_flexible_array
Date: Fri, 27 Sep 2024 16:39:37 -0300 [thread overview]
Message-ID: <ZvcJ-REjrrUfImcZ@x1> (raw)
In-Reply-To: <b1bbd9c1-d9f7-4305-b107-f4dc3f9827a9@embeddedor.com>
On Fri, Sep 27, 2024 at 09:22:46PM +0200, Gustavo A. R. Silva wrote:
> On 27/09/24 20:59, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > Hi,
> >
> > This implements --padding, that combined with the already
> > available --with_flexible_array option may catch some questionable
> > structs.
> >
> > This comes from a quick discussion I had with Willy Tareau after
> > Gustavo's talk at this year's Kernel Recipes.
>
> Nice. :)
>
> I think it'd be interesting to take a look at the output of the
> following command:
>
> $ pahole --padding_ge 1 --with_flexible_array
acme@x1:~$ pahole --padding_ge 1 --with_flexible_array > pahole--padding_ge_1_--with_flexible_array.`uname -r`.txt
acme@x1:~$ ls -lart pahole--padding_ge_1_--with_flexible_array.6.10.10-200.fc40.x86_64.txt
-rw-r--r--. 1 acme acme 172848 Sep 27 16:36 pahole--padding_ge_1_--with_flexible_array.6.10.10-200.fc40.x86_64.txt
acme@x1:~$
It is at http://vger.kernel.org/~acme/pahole--padding_ge_1_--with_flexible_array.6.10.10-200.fc40.x86_64.txt
> Acked-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks!
- Arnaldo
next prev parent reply other threads:[~2024-09-27 19:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 18:59 [PATCH 0/2] --padding option to combine with --with_flexible_array Arnaldo Carvalho de Melo
2024-09-27 18:59 ` [PATCH 1/2] pahole: Add --padding_ge N to show only structs with at least N bytes of padding at its end Arnaldo Carvalho de Melo
2024-09-27 18:59 ` [PATCH 2/2] pahole: Add --padding N to show only structs with " Arnaldo Carvalho de Melo
2024-09-27 19:22 ` [PATCH 0/2] --padding option to combine with --with_flexible_array Gustavo A. R. Silva
2024-09-27 19:39 ` Arnaldo Carvalho de Melo [this message]
2024-09-27 20:08 ` Gustavo A. R. Silva
2024-09-27 21:15 ` Willy Tarreau
2024-09-28 4:36 ` Willy Tarreau
2024-09-30 14:32 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvcJ-REjrrUfImcZ@x1 \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=alan.maguire@oracle.com \
--cc=dwarves@vger.kernel.org \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=jolsa@kernel.org \
--cc=kcarcia@redhat.com \
--cc=w@1wt.eu \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.