From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F1F714A96 for ; Sat, 28 Sep 2024 08:48:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727513288; cv=none; b=Oz/6ISY4NraK+SvRg1YvSKD13IfpRymjYvhXOHQxFrAZH8c5zR18NRBJZCsSdlmTWU4AO6+BeLiQWhvdx6XQj05o0WOkOzODwo1e1YuQOtGZAxZg1g3bFk91ZFhzudF3oAhsQKCIQaY51yqYAwRJ5sewUOwoZshCYZfR/PL5LWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727513288; c=relaxed/simple; bh=sXIgUiZDy0ZFxDCXCC/FGl5QKkhSTEbaILTWcCx4PvY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z2NF40teGv2et3Kore5zpCg6fdsX0P+fjrS3hT2LT8FEKSUmJerna0mFvWkZLfzL8Cn/0R4TfONymFOn+4+MB2L1Mp5aW0uoLy14ymgQK8knWn6Qs3S0pcnl+Hy5TNKjSojMnOcFz49SEpvRNBCXLiI2uiw2lxwlGqtglR26mc0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EV6Dhop7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EV6Dhop7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2566AC4CEC3; Sat, 28 Sep 2024 08:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727513287; bh=sXIgUiZDy0ZFxDCXCC/FGl5QKkhSTEbaILTWcCx4PvY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EV6Dhop7TMzaTv0DDArg6ss5fzSlX3qDUmWkAsCaAMtihBZHO6geqnihxVE1vo3xw YSw7G3XitCkbdwgRaxUADAwgWtOHXUEWYSyVbvtgs5LAeNIzuPK8e8Q1/45Z2e7SaN U2Saa/Jzus4M8iursJUijGEqBfRmL0VDWy35IZ1xUGecGmUjHXNyupsPEYBXMyc9JJ A3Eo9PqBRqIYaULO+ktAIwQVgbpUzG8OUrIDQoLGv6d/M1sOCgRNytqgLDRwLZAWyt YR0x5u40IFy1kexO1pESmP5ptPwP8ZxrbP+7vLgQjm6MBdKrBZo36foTqTSInBFK4E Q61R6RljQQ/ew== Date: Sat, 28 Sep 2024 10:48:03 +0200 From: Alexey Gladkov To: Callum Andrew Cc: kbd@lists.linux.dev Subject: Re: [PATCH v2] Update Colemak-DH keymaps with upstream changes Message-ID: References: <20240928012936.22351-1-contact@candrew.net> Precedence: bulk X-Mailing-List: kbd@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240928012936.22351-1-contact@candrew.net> On Sat, Sep 28, 2024 at 11:29:34AM +1000, Callum Andrew wrote: > - Make Wide Mod mappings consistent with specification Don't mix file modifications and file renaming. > - Rename from mod-dh (the name of the project) to colemak-dh (the name > of the layout) This renaming looks useless to me. The "colemak" is already present in the path. You can always do that: loadkeys colemak/mod-dh-ansi-us in the same way as loadkeys qwerty/cz This is how keymaps search has been working for a very long time. Duplicating the architecture, keymaps family, and everything else (in most cases) but the language is bad practice. I can understand why the author of colemak keymaps named them that in his standalone project. But in kbd such naming does not seem correct to me. > Signed-off-by: Callum Andrew > --- > ...-dh-ansi-us-awing.map => colemak-dh-ansi-us-awing.map} | 0 > ...-us-fatz-wide.map => colemak-dh-ansi-us-fatz-wide.map} | 4 ++-- > ...od-dh-ansi-us-fatz.map => colemak-dh-ansi-us-fatz.map} | 0 > ...od-dh-ansi-us-wide.map => colemak-dh-ansi-us-wide.map} | 4 ++-- > .../{mod-dh-ansi-us.map => colemak-dh-ansi-us.map} | 0 > ...{mod-dh-iso-uk-wide.map => colemak-dh-iso-uk-wide.map} | 8 ++++---- > .../colemak/{mod-dh-iso-uk.map => colemak-dh-iso-uk.map} | 0 > ...{mod-dh-iso-us-wide.map => colemak-dh-iso-us-wide.map} | 8 ++++---- > .../colemak/{mod-dh-iso-us.map => colemak-dh-iso-us.map} | 0 > .../{mod-dh-matrix-us.map => colemak-dh-matrix-us.map} | 0 > 10 files changed, 12 insertions(+), 12 deletions(-) > rename data/keymaps/i386/colemak/{mod-dh-ansi-us-awing.map => colemak-dh-ansi-us-awing.map} (100%) > rename data/keymaps/i386/colemak/{mod-dh-ansi-us-fatz-wide.map => colemak-dh-ansi-us-fatz-wide.map} (97%) > rename data/keymaps/i386/colemak/{mod-dh-ansi-us-fatz.map => colemak-dh-ansi-us-fatz.map} (100%) > rename data/keymaps/i386/colemak/{mod-dh-ansi-us-wide.map => colemak-dh-ansi-us-wide.map} (97%) > rename data/keymaps/i386/colemak/{mod-dh-ansi-us.map => colemak-dh-ansi-us.map} (100%) > rename data/keymaps/i386/colemak/{mod-dh-iso-uk-wide.map => colemak-dh-iso-uk-wide.map} (94%) > rename data/keymaps/i386/colemak/{mod-dh-iso-uk.map => colemak-dh-iso-uk.map} (100%) > rename data/keymaps/i386/colemak/{mod-dh-iso-us-wide.map => colemak-dh-iso-us-wide.map} (94%) > rename data/keymaps/i386/colemak/{mod-dh-iso-us.map => colemak-dh-iso-us.map} (100%) > rename data/keymaps/i386/colemak/{mod-dh-matrix-us.map => colemak-dh-matrix-us.map} (100%) -- Rgrds, legion