From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F65ECF6499 for ; Sun, 29 Sep 2024 10:53:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K0A2Q5KSnwhe7elTVoz9qmkuI7VZklxDwZD2vV/oTRI=; b=THszKtwsHfSDFF cClDxZHoFzu9mT6uih58a4oioDzCVSH7QuvpZKITyxAZL+QZ+7J2lQjWcq9HfSn9NTHtakExRgB3O cfzc7oGhGta3GzjpEdkhOOWmQ0FKJLIEukdJZ64GOP01Lzt0tyRSGHnicEf/LjvWBDKPPt2MwN3yJ xxeoZhMMVpaLUKDvq0m9UGtN59QP9DXTYbtH/qS/XGxf01YFlLhG8lnmcBLHTKKfvLgZxVAgOvoml dSQ4JP2wv9KRq0ZwECJGgaEWcaiXgH3lXZEwSjAYC5XsTUAnG+2d1FxztuEf+11qXAALjtKChPnMC 8VPviE+oHAXi2fukbewA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1surYG-0000000EdbN-4B9N; Sun, 29 Sep 2024 10:53:20 +0000 Received: from pidgin.makrotopia.org ([2a07:2ec0:3002::65]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1surYE-0000000Edab-2KjC for linux-mtd@lists.infradead.org; Sun, 29 Sep 2024 10:53:20 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98) (envelope-from ) id 1surY2-000000007Ck-3WVz; Sun, 29 Sep 2024 10:53:06 +0000 Date: Sun, 29 Sep 2024 11:52:59 +0100 From: Daniel Golle To: Zhihao Cheng Cc: Krzysztof Kozlowski , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , John Crispin , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 1/2] dt-bindings: mtd: ubi-volume: add 'volume-is-critical' property Message-ID: References: <7a2e8819-ac70-4070-a731-53994c72cd79@kernel.org> <18e9d774-813b-427e-9938-53853d695e18@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240929_035318_624188_258C5570 X-CRM114-Status: GOOD ( 41.98 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gU3VuLCBTZXAgMjksIDIwMjQgYXQgMTI6MDM6MTFQTSArMDgwMCwgWmhpaGFvIENoZW5nIHdy b3RlOgo+IOWcqCAyMDI0LzkvMjggMjI6MzgsIERhbmllbCBHb2xsZSDlhpnpgZM6Cj4gPiBPbiBT YXQsIFNlcCAyOCwgMjAyNCBhdCAwMzo0NTo0OVBNICswMjAwLCBLcnp5c3p0b2YgS296bG93c2tp IHdyb3RlOgo+ID4gPiBPbiAyOC8wOS8yMDI0IDE1OjA5LCBEYW5pZWwgR29sbGUgd3JvdGU6Cj4g PiA+ID4gT24gU2F0LCBTZXAgMjgsIDIwMjQgYXQgMDM6MDI6NDdQTSArMDIwMCwgS3J6eXN6dG9m IEtvemxvd3NraSB3cm90ZToKPiA+ID4gPiA+IE9uIDI4LzA5LzIwMjQgMTQ6NDcsIERhbmllbCBH b2xsZSB3cm90ZToKPiA+ID4gPiA+ID4gQWRkIHRoZSAndm9sdW1lLWlzLWNyaXRpY2FsJyBib29s ZWFuIHByb3BlcnR5IHdoaWNoIG1hcmtzIGEgVUJJIHZvbHVtZQo+ID4gPiA+ID4gPiBhcyBjcml0 aWNhbCBmb3IgdGhlIGRldmljZSB0byBib290LiBJZiBzZXQgaXQgcHJldmVudHMgdGhlIHVzZXIg ZnJvbQo+ID4gPiA+ID4gPiBhbGwga2luZHMgb2Ygd3JpdGUgYWNjZXNzIHRvIHRoZSB2b2x1bWUg YXMgd2VsbCBhcyBmcm9tIHJlbmFtaW5nIGl0IG9yCj4gPiA+ID4gPiA+IGRldGFjaGluZyB0aGUg VUJJIGRldmljZSBpdCBpcyBsb2NhdGVkIG9uLgo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gU2ln bmVkLW9mZi1ieTogRGFuaWVsIEdvbGxlIDxkYW5pZWxAbWFrcm90b3BpYS5vcmc+Cj4gPiA+ID4g PiA+IC0tLQo+ID4gPiA+ID4gPiAgIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL210ZC9wYXJ0aXRp b25zL3ViaS12b2x1bWUueWFtbCAgIHwgOSArKysrKysrKysKPiA+ID4gPiA+ID4gICAxIGZpbGUg Y2hhbmdlZCwgOSBpbnNlcnRpb25zKCspCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBkaWZmIC0t Z2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL210ZC9wYXJ0aXRpb25zL3Vi aS12b2x1bWUueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tdGQvcGFy dGl0aW9ucy91Ymktdm9sdW1lLnlhbWwKPiA+ID4gPiA+ID4gaW5kZXggMTk3MzZiMjYwNTZiLi4y YmQ3NTFiYjdmOWUgMTAwNjQ0Cj4gPiA+ID4gPiA+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9tdGQvcGFydGl0aW9ucy91Ymktdm9sdW1lLnlhbWwKPiA+ID4gPiA+ID4g KysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL210ZC9wYXJ0aXRpb25zL3Vi aS12b2x1bWUueWFtbAo+ID4gPiA+ID4gPiBAQCAtMjksNiArMjksMTUgQEAgcHJvcGVydGllczoK PiA+ID4gPiA+ID4gICAgICAgZGVzY3JpcHRpb246Cj4gPiA+ID4gPiA+ICAgICAgICAgVGhpcyBj b250YWluZXIgbWF5IHJlZmVyZW5jZSBhbiBOVk1FTSBsYXlvdXQgcGFyc2VyLgo+ID4gPiA+ID4g PiArICB2b2x1bWUtaXMtY3JpdGljYWw6Cj4gPiA+ID4gPiA+ICsgICAgZGVzY3JpcHRpb246IFRo aXMgcGFyYW1ldGVyLCBpZiBwcmVzZW50LCBpbmRpY2F0ZXMgdGhhdCB0aGUgVUJJIHZvbHVtZQo+ ID4gPiA+ID4gPiArICAgICAgY29udGFpbnMgZWFybHktYm9vdCBmaXJtd2FyZSBpbWFnZXMgb3Ig ZGF0YSB3aGljaCBzaG91bGQgbm90IGJlIGNsb2JiZXJlZC4KPiA+ID4gPiA+ID4gKyAgICAgIElm IHNldCwgaXQgcHJldmVudHMgdGhlIHVzZXIgZnJvbSByZW5hbWluZyB0aGUgdm9sdW1lLCB3cml0 aW5nIHRvIGl0IG9yCj4gPiA+ID4gPiA+ICsgICAgICBtYWtpbmcgYW55IGNoYW5nZXMgYWZmZWN0 aW5nIGl0LCBhcyB3ZWxsIGFzIGRldGFjaGluZyB0aGUgVUJJIGRldmljZSBpdCBpcwo+ID4gPiA+ ID4gPiArICAgICAgbG9jYXRlZCBvbiwgc28gZGlyZWN0IGFjY2VzcyB0byB0aGUgdW5kZXJseWlu ZyBNVEQgZGV2aWNlIGlzIHByZXZlbnRlZCBhcwo+ID4gPiA+ID4gPiArICAgICAgd2VsbC4KPiA+ ID4gPiA+ID4gKyAgICB0eXBlOiBib29sZWFuCj4gPiA+ID4gPiAKPiA+ID4gPiA+IFVCSSB2b2x1 bWVzIGFyZSBtYXBwaW5nIHRvIHBhcnRpdGlvbnMgMS10by0xLCByaWdodD8gU28gcmF0aGVyIEkg d291bGQKPiA+ID4gPiA+IHByb3Bvc2UgdG8gdXNlIHBhcnRpdGlvbi55YW1sIC0gd2UgYWxyZWFk eSBoYXZlIHJlYWQtb25seSB0aGVyZSB3aXRoCj4gPiA+ID4gPiB2ZXJ5IHNpbWlsYXIgZGVzY3Jp cHRpb24uCj4gPiA+ID4gCj4gPiA+ID4gTm8sIHRoYXQncyBub3QgdGhlIGNhc2UuCj4gPiA+ID4g Cj4gPiA+ID4gQW4gTVREIHBhcnRpdGlvbiBjYW4gYmUgdXNlZCBhcyBVQkkgZGV2aWNlLiBBIFVC SSBkZXZpY2UgKGFuZCBoZW5jZSBNVEQKPiA+ID4gPiBwYXJ0aXRpb24pIGNhbiBob3N0ICpzZXZl cmFsKiBVQkkgdm9sdW1lcy4KPiA+ID4gPiAKPiA+ID4gPiBNYXJraW5nIHRoZSBNVEQgcGFydGl0 aW9uIGFzICdyZWFkLW9ubHknIHdvbid0IHdvcmssIGFzIFVCSSBuZWVkcwo+ID4gPiA+IHJlYWQt d3JpdGUgYWNjZXNzIHRvIHBlcmZvcm0gYmFkIGJsb2NrIHJlbG9jYXRpb24sIHNjcnViYmluZywg Li4uCj4gPiA+IAo+ID4gPiBPSywgc28gbm90IHBhcnRpdGlvbiBidXQgcmVhZC1vbmx5IHZvbHVt ZS4KPiA+IAo+ID4gKzEKPiA+IAo+ID4gPiAKPiA+ID4gPiAKPiA+ID4gPiBBbHNvLCB0eXBpY2Fs bHkgbm90IGFsbCBVQkkgdm9sdW1lcyBvbiBhIFVCSSBkZXZpY2UgYXJlCj4gPiA+ID4gcmVhZC1v bmx5L2NyaXRpY2FsIGJ1dCBvbmx5IGEgc3Vic2V0IG9mIHRoZW0uCj4gPiA+ID4gCj4gPiA+ID4g QnV0IHlvdSBhcmUgcmlnaHQgdGhhdCB0aGUgZGVzY3JpcHRpb24gaXMgaW5zcGlyZWQgYnkgdGhl IGRlc2NyaXB0aW9uCj4gPiA+ID4gb2YgdGhlICdyZWFkLW9ubHknIHByb3BlcnR5IGluIHBhcnRp dGlvbi55YW1sIDspCj4gPiA+ID4gCj4gPiA+ID4gSSBpbml0aWFsbHkgdGhvdWdodCB0byBhbHNv IG5hbWUgdGhlIHByb3BlcnR5ICdyZWFkLW9ubHknLCBqdXN0IGxpa2UKPiA+ID4gPiBmb3IgTVRE IHBhcnRpdGlvbnMuIEhvd2V2ZXIsIGFzIHRoZSBkZXNpcmVkIGVmZmVjdCBnb2VzIGJleW9uZAo+ ID4gPiA+IHByZXZlbnRpbmcgd3JpdGUgYWNjZXNzIHRvIHRoZSB2b2x1bWUgaXRzZWxmLCBJIHRo b3VnaHQgaXQnZCBiZQo+ID4gPiA+IGJldHRlciB0byB1c2UgYSBuZXcgbmFtZS4KPiA+ID4gCj4g PiA+IFllYWgsIG1heWJlLi4uIGNyaXRpY2FsIGluZGVlZCBjb3ZlcnMgbXVsdGlwbGUgY2FzZXMg YnV0IGlzIGFsc28KPiA+ID4gc3ViamVjdGl2ZS4gRm9yIHNvbWUgYm9vdGxvYWRlciBpcyBjcml0 aWNhbCwgZm9yIG90aGVyIGJvb3Rsb2FkZXIgc3RpbGwKPiA+ID4gbWlnaHQgYmUgZnVsbHkgQS9C IHVwZGF0ZWFibGUgdGh1cyBjb3VsZCBiZSBtb2RpZmlhYmxlLiBGb3Igb3RoZXJzLCB0aGV5Cj4g PiA+IHdhbnQgdG8gdXNlIGZ3X3NldGVudiBmcm9tIHVzZXItc3BhY2Ugc28gbm90IGNyaXRpY2Fs IGF0IGFsbC4KPiA+IAo+ID4gVGhlIGNhc2UgSSB3YW50IHRvIGNvdmVyIGhlcmUgaXMgdGhlIGJv b3Rsb2FkZXIgaXRzZWxmIGJlaW5nIHN0b3JlZAo+ID4gaW5zaWRlIGEgVUJJIHZvbHVtZS4gTWVk aWFUZWsncyBmb3JrIG9mIEFSTSBUcnVzdGVkRmlybXdhcmUtQSBibDIgY29tZXMKPiA+IHdpdGgg c3VwcG9ydCBmb3IgVUJJIGFuZCBsb2FkcyBCTDMgKHdoaWNoIGlzIFRGLUEgQkwzMSBhbmQgVS1C b290LCBhbmQKPiA+IG1heWJlIE9QLVRFRSBhcyB3ZWxsKSBmcm9tIGEgc3RhdGljIFVCSSB2b2x1 bWUuIFJlbW92aW5nLCByZW5hbWluZyBvcgo+ID4gYWx0ZXJpbmcgdGhhdCB2b2x1bWUgcmVzdWx0 cyBpbiB0aGUgZGV2aWNlIG5vdCBiZWluZyBhYmxlIHRvIGJvb3QgYW55Cj4gPiBtb3JlIGFuZCBy ZXF1aXJpbmcgYSBjb21wbGljYXRlZCBpbnRlcnZlbnRpb24gKGF0IGF0dGFjaGluZyBkZWJ1Z2dp bmcKPiA+IFVBUlQgYW5kIHVzaW5nIGxvdy1sZXZlbCByZWNvdmVyeSB0b29sKSBpbiBvcmRlciB0 byByZWNvdmVyLgo+IAo+IFdobyByZW1vdmVzL3JlbmFtZXMgdGhlICdjcml0aWNhbCcgdm9sdW1l PyBJIHN1Z2dlc3QgdG8gZml4IGl0IGluIHRoZSB1cHBlcgo+IGxheWVyKG5vdCBpbiBrZXJuZWwp LiBBZnRlciBsb29raW5nIHRocm91Z2ggdGhlIHBhdGNoIDIsIGl0IHNlZW1zIGEgaGFjawo+IHNv bHV0aW9uLgoKVGhlIGVuZW15IGlzIHRoZSB1c2VyLCB0aGUgdXBwZXIgbGF5ZXIgaXMgYmV0d2Vl biB0aGUga2V5Ym9hcmQgYW5kIHRoZQpzY3JlZW4uIEp1c3QgbGlrZSBmb3IgJ3JlYWQtb25seScg TVREIHBhcnRpdGlvbnMgSSdtIGxvb2tpbmcKZm9yIGEgc2ltaWxhciBzb2x1dGlvbiBmb3IgVUJJ IHdoaWNoIHByZXZlbnRzIHRoZSB1c2VyIGZyb20gYWNjaWRlbnRhbGx5CmRlbGV0aW5nIG9yIGRl c3Ryb3lpbmcgdGhlIGJvb3Rsb2FkZXIsIGxldHMgc2F5LCB3aGVuIGxvZ2dlZCBpbiB2aWEgU1NI LgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75DE1152E1C; Sun, 29 Sep 2024 10:53:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727607199; cv=none; b=qsPV5UuClOwtUe8KRvt/N6ejL9UEhihHQvuYXKMkXxzJEdvV4iMlo8rlNHWviqSGhwsXni2LDjrVqH0fOoeJLQ6xi9O3/n7BCQ4+KExg6ZT4PwEb3G5H8EP2XTesPMCAVw6g2APCR4g+yjBamYQOCl7TUa/l6f/nUUH+q9++4QE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727607199; c=relaxed/simple; bh=cPqISAcZ4H8167b3x7BdNIv2c5BtODWuLOlPU3TW730=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KVhT1/1aINwAZnAIPotz4RmYE9N1uRqSYjVevyL6WEREDZxWsar+Llp1pBrJ7J/+JTs9xmHhSva15yx8kneIMPOdyvzQ+EEqV7VMU54L7DfSaQNf40oR27Z17x9+6bK3K8QsuBTQ2FbnbfIE0hi4JkEtICTYII6/9siW5grU2l0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98) (envelope-from ) id 1surY2-000000007Ck-3WVz; Sun, 29 Sep 2024 10:53:06 +0000 Date: Sun, 29 Sep 2024 11:52:59 +0100 From: Daniel Golle To: Zhihao Cheng Cc: Krzysztof Kozlowski , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , John Crispin , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 1/2] dt-bindings: mtd: ubi-volume: add 'volume-is-critical' property Message-ID: References: <7a2e8819-ac70-4070-a731-53994c72cd79@kernel.org> <18e9d774-813b-427e-9938-53853d695e18@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Sep 29, 2024 at 12:03:11PM +0800, Zhihao Cheng wrote: > 在 2024/9/28 22:38, Daniel Golle 写道: > > On Sat, Sep 28, 2024 at 03:45:49PM +0200, Krzysztof Kozlowski wrote: > > > On 28/09/2024 15:09, Daniel Golle wrote: > > > > On Sat, Sep 28, 2024 at 03:02:47PM +0200, Krzysztof Kozlowski wrote: > > > > > On 28/09/2024 14:47, Daniel Golle wrote: > > > > > > Add the 'volume-is-critical' boolean property which marks a UBI volume > > > > > > as critical for the device to boot. If set it prevents the user from > > > > > > all kinds of write access to the volume as well as from renaming it or > > > > > > detaching the UBI device it is located on. > > > > > > > > > > > > Signed-off-by: Daniel Golle > > > > > > --- > > > > > > .../devicetree/bindings/mtd/partitions/ubi-volume.yaml | 9 +++++++++ > > > > > > 1 file changed, 9 insertions(+) > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/mtd/partitions/ubi-volume.yaml b/Documentation/devicetree/bindings/mtd/partitions/ubi-volume.yaml > > > > > > index 19736b26056b..2bd751bb7f9e 100644 > > > > > > --- a/Documentation/devicetree/bindings/mtd/partitions/ubi-volume.yaml > > > > > > +++ b/Documentation/devicetree/bindings/mtd/partitions/ubi-volume.yaml > > > > > > @@ -29,6 +29,15 @@ properties: > > > > > > description: > > > > > > This container may reference an NVMEM layout parser. > > > > > > + volume-is-critical: > > > > > > + description: This parameter, if present, indicates that the UBI volume > > > > > > + contains early-boot firmware images or data which should not be clobbered. > > > > > > + If set, it prevents the user from renaming the volume, writing to it or > > > > > > + making any changes affecting it, as well as detaching the UBI device it is > > > > > > + located on, so direct access to the underlying MTD device is prevented as > > > > > > + well. > > > > > > + type: boolean > > > > > > > > > > UBI volumes are mapping to partitions 1-to-1, right? So rather I would > > > > > propose to use partition.yaml - we already have read-only there with > > > > > very similar description. > > > > > > > > No, that's not the case. > > > > > > > > An MTD partition can be used as UBI device. A UBI device (and hence MTD > > > > partition) can host *several* UBI volumes. > > > > > > > > Marking the MTD partition as 'read-only' won't work, as UBI needs > > > > read-write access to perform bad block relocation, scrubbing, ... > > > > > > OK, so not partition but read-only volume. > > > > +1 > > > > > > > > > > > > > Also, typically not all UBI volumes on a UBI device are > > > > read-only/critical but only a subset of them. > > > > > > > > But you are right that the description is inspired by the description > > > > of the 'read-only' property in partition.yaml ;) > > > > > > > > I initially thought to also name the property 'read-only', just like > > > > for MTD partitions. However, as the desired effect goes beyond > > > > preventing write access to the volume itself, I thought it'd be > > > > better to use a new name. > > > > > > Yeah, maybe... critical indeed covers multiple cases but is also > > > subjective. For some bootloader is critical, for other bootloader still > > > might be fully A/B updateable thus could be modifiable. For others, they > > > want to use fw_setenv from user-space so not critical at all. > > > > The case I want to cover here is the bootloader itself being stored > > inside a UBI volume. MediaTek's fork of ARM TrustedFirmware-A bl2 comes > > with support for UBI and loads BL3 (which is TF-A BL31 and U-Boot, and > > maybe OP-TEE as well) from a static UBI volume. Removing, renaming or > > altering that volume results in the device not being able to boot any > > more and requiring a complicated intervention (at attaching debugging > > UART and using low-level recovery tool) in order to recover. > > Who removes/renames the 'critical' volume? I suggest to fix it in the upper > layer(not in kernel). After looking through the patch 2, it seems a hack > solution. The enemy is the user, the upper layer is between the keyboard and the screen. Just like for 'read-only' MTD partitions I'm looking for a similar solution for UBI which prevents the user from accidentally deleting or destroying the bootloader, lets say, when logged in via SSH.