From: Tudor Gheorghiu <tudor.reda@gmail.com>
To: Dirk Behme <dirk.behme@de.bosch.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: re-order exports to fix rustfmt
Date: Mon, 30 Sep 2024 08:09:12 +0300 [thread overview]
Message-ID: <ZvoyeO8pUJBwkYEM@redaops> (raw)
In-Reply-To: <6d08a751-fbeb-4dd2-af78-32ae89704208@de.bosch.com>
On Mon, Sep 30, 2024 at 06:15:32AM +0200, Dirk Behme wrote:
> On 30.09.2024 03:09, Tudor Gheorghiu wrote:
> > In the recent rust-6.12 tag merge at 570172569238, the rbtree export was
> > added after the sizes export, thus breaking rustfmt's alphabetical
> > export ordering rules.
> >
> > Signed-off-by: Tudor Gheorghiu <tudor.reda@gmail.com>
> > ---
> > rust/kernel/lib.rs | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
> > index 22a3bfa5a9e9..b5f4b3ce6b48 100644
> > --- a/rust/kernel/lib.rs
> > +++ b/rust/kernel/lib.rs
> > @@ -44,8 +44,8 @@
> > pub mod page;
> > pub mod prelude;
> > pub mod print;
> > -pub mod sizes;
> > pub mod rbtree;
> > +pub mod sizes;
> > mod static_assert;
> > #[doc(hidden)]
>
> I think we have that in rust-fixes already:
>
> https://github.com/Rust-for-Linux/linux/commit/ece207a83e464af710d641f29e32b7a144c48e79
>
> Dirk
>
You are correct! I didn't check rust-fixes, as I was working on
something else when I noticed this.
Thanks!
Have a great day!
Tudor
prev parent reply other threads:[~2024-09-30 5:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 1:09 [PATCH] rust: re-order exports to fix rustfmt Tudor Gheorghiu
2024-09-30 4:15 ` Dirk Behme
2024-09-30 5:09 ` Tudor Gheorghiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvoyeO8pUJBwkYEM@redaops \
--to=tudor.reda@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dirk.behme@de.bosch.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.