Re: [PATCH] trusted-firmware-a: fix build error when using ccache

[Jon Mason <jdmason@kudzu.us>]

On Sat, Sep 28, 2024 at 05:54:36PM +0200, Adrian DC wrote:
> From: Javier Tia <javier.tia@linaro.org>
> 
> When ccache is enabled trusted-firmware-a recipe fails with this
> error message:
> 
>     make: *** No rule to make target 'aarch64-poky-linux-gcc'. Stop.
> 
> ccache prefix CC variable with 'ccache' word before compiler. Because
> there are no quotes assigned to CC, only 'ccache' is assigned. The
> compiler becomes a make target, producing the build error.
> 
> Add single quotes to LD is a good measure to prevent this kind of error.
> 
> Signed-off-by: Javier Tia <javier.tia@linaro.org>
> Signed-off-by: Jon Mason <jon.mason@arm.com>
> Signed-off-by: Adrian DC <radian.dc@gmail.com>

I have questions about this patch's origins, given the above s-o-b's.
Signed-off-by's state an authorship or handling (see Developer’s
Certificate of Origin).  Since I have not seen this patch, I should
not be listed.  It's on me to add my s-o-b.  Also, the ordering tends
to matter, as each person handling the patch adds their s-o-b at the
end of the patch.  So, you should be second, since you are taking this
from Javier and submitting it for him (nd I would be last since
I'mtaking it from you).

Also, this feels like it needs a "Fixes:" line.  So, I know how far to
pull this back in the stable branches.

Finally, I find it weird that Javier isn't submitting this himself.
Javier appears to be the author, and it includes his Linaro emaila
ddress, and you are sending it from a gmail account.  Are you
co-authors?  Are you sending it with his approval because he is
busy/vacationing/ill?

Overall the patch is fine and I would normally include it, but this is
weird to me.  If Javier acks it to confirm his authoer, then I'll move
my s-o-b to the end and include it.

Thanks,
Jon


> ---
>  .../recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc     | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> index 2e3b50c5..5d3da59b 100644
> --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> @@ -101,9 +101,9 @@ def remove_options_tail (in_string):
>      from itertools import takewhile
>      return ' '.join(takewhile(lambda x: not x.startswith('-'), in_string.split(' ')))
>  
> -EXTRA_OEMAKE += "LD=${@remove_options_tail(d.getVar('LD'))}"
> +EXTRA_OEMAKE += "LD='${@remove_options_tail(d.getVar('LD'))}'"
>  
> -EXTRA_OEMAKE += "CC=${@remove_options_tail(d.getVar('CC'))}"
> +EXTRA_OEMAKE += "CC='${@remove_options_tail(d.getVar('CC'))}'"
>  
>  # Verbose builds, no -Werror
>  EXTRA_OEMAKE += "V=1 E=0"
> -- 
> 2.43.0
> 
>