All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: "linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	Vinod Koul <vkoul@kernel.org>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>
Subject: Re: [PATCH 1/3] dmaengine: sh: rz-dmac: handle configs where one address is zero
Date: Mon, 30 Sep 2024 21:25:29 +0200	[thread overview]
Message-ID: <Zvr7Keg9bPu6aUJM@shikoro> (raw)
In-Reply-To: <TY3PR01MB11346F2C786FD343B7B382CF386762@TY3PR01MB11346.jpnprd01.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]


> Now both code paths are identical, not sure may be introducing a helper
> by passing channel, CHCFG_FILL_*_MASK and *_addr_width
> will save some code??

I had a look and I don't think so because we'd need to pass so many
parameters to the helper, that it doesn't really save anything, I'd say.

> Anyway, current code LGTM. So,
> 
> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-09-30 19:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 14:59 [PATCH 0/3] dmaengine: sh: rz-dmac: add r7s72100 support Wolfram Sang
2024-09-30 14:59 ` [PATCH 1/3] dmaengine: sh: rz-dmac: handle configs where one address is zero Wolfram Sang
2024-09-30 16:40   ` Biju Das
2024-09-30 19:25     ` Wolfram Sang [this message]
2024-10-01  8:56       ` Biju Das
2024-10-01  6:29   ` claudiu beznea
2024-09-30 14:59 ` [PATCH 2/3] dt-bindings: dma: rz-dmac: Document RZ/A1L SoC Wolfram Sang
2024-09-30 15:18   ` Geert Uytterhoeven
2024-09-30 19:26     ` Wolfram Sang
2024-10-01  7:44       ` Biju Das
2024-09-30 14:59 ` [PATCH 3/3] dmaengine: sh: rz-dmac: add r7s72100 support Wolfram Sang
2024-09-30 15:12   ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zvr7Keg9bPu6aUJM@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.