All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Matthias Männich" <maennich@google.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
	peterz@infradead.org, void@manifault.com
Subject: Re: [PATCH] sched: fix include for task_cpu_possible
Date: Mon, 30 Sep 2024 07:02:41 -1000	[thread overview]
Message-ID: <ZvrZsQ-uXHFQsxII@slm.duckdns.org> (raw)
In-Reply-To: <20240930164455.2060692-2-maennich@google.com>

Hello,

On Mon, Sep 30, 2024 at 04:44:56PM +0000, Matthias Männich wrote:
> From: Matthias Maennich <maennich@google.com>
> 
> Commit 2c390dda9e03 ("sched_ext: Make task_can_run_on_remote_rq() use
> common task_allowed_on_cpu()") moved the call for task_cpu_possible from
> kernel/sched/core.c, but did not add an include of linux/mmu_context.h
> where this symbol is defined. Fix that by adding the missing include.
> 
> Fixes: 2c390dda9e03 ("sched_ext: Make task_can_run_on_remote_rq() use common task_allowed_on_cpu()")
> Signed-off-by: Matthias Maennich <maennich@google.com>
> ---
>  kernel/sched/sched.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index e2b7c5282f5d..a7832c53cc92 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -44,6 +44,7 @@
>  #include <linux/lockdep.h>
>  #include <linux/minmax.h>
>  #include <linux/mm.h>
> +#include <linux/mmu_context.h>

Should the patch also remove mmu_context.h from kernel/sched/core.c?

Thanks.

-- 
tejun

  reply	other threads:[~2024-09-30 17:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 16:44 [PATCH] sched: fix include for task_cpu_possible Matthias Männich
2024-09-30 17:02 ` Tejun Heo [this message]
2024-09-30 23:48   ` Matthias Männich
2024-10-01 19:46     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvrZsQ-uXHFQsxII@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maennich@google.com \
    --cc=peterz@infradead.org \
    --cc=void@manifault.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.